search

Apple-Actions / download-provisioning-profiles

Github Action for downloading provisioning profiles from Apple AppStore Connect
MIT License
74 stars 37 forks source link

Update package-lock.json & fix build failures #14

Closed simba909 closed 5 months ago

simba909 commented 2 years ago

Noticed that build failures have started popping up recently, so investigated a bit and found that npm install resolves a commit of the appstoreconnect dependency that doesn't contain the latest changes in orj/appstoreconnect (as a matter of fact, I can't even find the commit it is referencing).

This PR is unfortunately unreadably large since I had to npm update appstoreconnect for it to update to a working version. Updated the package-lock.json using Node 16.13.1 which seems to have rebuilt the whole thing..

Edit: noticed that CI still failed to build after the above, so ran npm run all locally and fixed the lint issue which is in the second commit (this also rebuilt index.js, again).

Edit 2: Ok, seems that the tests are now failing. Will have to look into that, but any pointers would be helpful 🤔

Not in any way, shape, or form a JS dev so feel free to point me in the correct direction if this isn't the right way to solve this issue.

simba909 commented 5 months ago

Closing this since it's no longer relevant.