search

Apple-Actions / import-codesign-certs

GitHub Action for Importing Code-signing Certificates into a Keychain
MIT License
184 stars 78 forks source link

Deprecated node12, migrate to node 16 #28

Closed jellespijker closed 1 year ago

jellespijker commented 1 year ago

Hi,

Since I'm more of a C++/Python dev I don't known if the warning from our runners is a concern that needs to be addressed but as of today we received the following warning:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: apple-actions/import-codesign-certs

https://github.com/Ultimaker/Cura/actions/runs/3232797852

FelixLisczyk commented 1 year ago

There is another deprecation warning when using this action:

Run apple-actions/import-codesign-certs@v1
  with:
    p12-file-base64: ***
    p12-password: ***
    keychain: signing_temp
    create-keychain: true
Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
ssrobins commented 1 year ago

Posted a pull request that addresses this: https://github.com/Apple-Actions/import-codesign-certs/pull/41