Apple-Actions / import-codesign-certs

GitHub Action for Importing Code-signing Certificates into a Keychain
MIT License
184 stars 78 forks source link

Recompile index.js and upgrade actions/core to fix all errors/warnings #41

Closed ssrobins closed 1 year ago

ssrobins commented 1 year ago

This work fixes the following issues: https://github.com/Apple-Actions/import-codesign-certs/issues/28 https://github.com/Apple-Actions/import-codesign-certs/issues/29 https://github.com/Apple-Actions/import-codesign-certs/issues/40

To fix the runtime error in GitHub Actions, I ran the commands in the contributing doc. Then, following the steps in this tutorial, ran the following to update index.js: ncc build src/main.ts --license licenses.txt

I followed the recommendations in this blog to upgrade @actions/core to v1.10.0, which got rid of the runtime warning in GitHub Actions.

rcdailey commented 1 year ago

Any reason why this hasn't been merged yet?

erikng commented 1 year ago

I'm trying your fork/PR and the errors are gone. Looks like the certs imported properly as well.

steveoh commented 1 year ago

@orj are you managing these pr's or does this repo need a new maintainer?

ssrobins commented 1 year ago

@orj are you managing these pr's or does this repo need a new maintainer?

@orj feel free to assign the repo to me, if you like. Grateful you set it up in the first place, but it doesn't mean you have to maintain it forever. It takes a village and all that :)

orj commented 1 year ago

@ssrobins Thanks for the offer. I've added you to the org.

ssrobins commented 1 year ago

Thanks @orj! I guess the next step would be to make a v2 tag from latest master and push it, do you agree? I don't have access to do that, though.

orj commented 1 year ago

Ah. I'll probably have to tweak the repo permissions. I'll have to do that when I get in to work tomorrow.

ssrobins commented 1 year ago

@orj any updates on this?

orj commented 1 year ago

@orj any updates on this?

You should have write permissions.

ssrobins commented 1 year ago

@orj any updates on this?

You should have write permissions.

Thanks, it works. v2 tag is now pushed and apple-actions/import-codesign-certs@v2 action now works!