Apple-Actions / import-codesign-certs

GitHub Action for Importing Code-signing Certificates into a Keychain
MIT License
184 stars 78 forks source link

Node.js 16 actions are deprecated #57

Closed pllim closed 3 months ago

pllim commented 10 months ago

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: apple-actions/import-codesign-certs@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

https://github.com/Apple-Actions/import-codesign-certs/blob/5565bb656f60c98c8fc515f3444dd8db73545dc2/action.yml#L31

grzegorzkrukowski commented 6 months ago

GitHub announced that they will enforce node20 instead of a warning on 13th May

paulmcgrathparamount commented 5 months ago

There's a PR awaiting merging for this issue - https://github.com/Apple-Actions/import-codesign-certs/pull/58 - but in the meantime one workaround I found was to check the logs of the git workflow where this action is called and copying the security commands output by the script. Then I just replace the invocation of this action with running those commands directly. Probably not an ideal solution but it does get rid of the deprecation warning.

ssrobins commented 3 months ago

Upgraded with https://github.com/Apple-Actions/import-codesign-certs/pull/64

pllim commented 3 months ago

Thanks!