Open jozefizso opened 9 months ago
Hi @orj, can you check out this PR?
Are there any updates on this PR? Thank you for your work! 😊
When this is going to be merged?
GitHub announced that they will enforce node20 instead of a warning on 13th May
Any updates on this PR getting merged?
You can use this fork until this gets merged:
@orj any news about this PR?
You can use this fork until this gets merged:
@jozefizso's fork is working perfectly
In the meantime, it can be integrated with uses: slidoapp/import-codesign-certs@node20
Ty dude :)
Just to be clear I mention that this PR has not moved in 5 months and using @XaviTorello suggestion until it does. Why is this taking so long is this project dead?
Hi @orj , I hope you are doing well.
I'm checking if you could review this PR so others can enjoy the import-codesign-certs
action running on latest NodeJS 20 runtime.
Thanks for your patience here. I was added as a maintainer to help with the node 16 upgrade, but I neglected to hit 'watch' on the repo so I wasn't getting any notifications. I also wasn't using my GitHub hobby projects much so I didn't see the deprecation warning until recently.
Node is now upgraded to 20 with https://github.com/Apple-Actions/import-codesign-certs/pull/64 and I added a v3
tag with those changes. I'm not closing this PR since there are some valuable upgrades here. I can try to get to this next week, perhaps. In the meantime, if you wanted to update your branch to re-run the checks, that would be helpful.
I originally checked out this pr before making #64 but decided to make mine because just changing to node20 would possibly make the review faster. These upgrades seem fine after testing it locally and inside my github action since its just upgrades of devDependencies.
Thanks for the update! It would be great to also update the apple-actions/download-provisioning-profiles
action since you're at it
Thanks for the update! It would be great to also update the
apple-actions/download-provisioning-profiles
action since you're at it
It's done, please use apple-actions/download-provisioning-profiles@v3
.
Great work @ssrobins It would be super to also update Apple-Actions/upload-testflight-build
Hi @ssrobins, thanks for looking at this PR.
I have rebased it on the master
and update npm package to latest version.
I did not update the eslint
as the latest major release is not compatible with the @typescript-eslint/parser
.
Fixes #57 Fixes #56