search

AppleDash / SaneEconomy

Finally, a sane economy plugin for Bukkit.
https://www.spigotmc.org/resources/saneeconomy-simple-but-featureful-economy.26223/
GNU General Public License v3.0
19 stars 24 forks source link

Feature or issue? Non-Player accounts. #4

Closed FrostTaco closed 8 years ago

FrostTaco commented 8 years ago

Recently I had an issue with factions, as disbanding would give an error. Was then given a new version of SaneEconomy to fix it. I posted on factions asking them to fix: Invalid player name to a vault api method, and here was the response(I kind of need factions to use the economy, please :P):

`Factions can have accounts, usually economy plugins handle this farley well.

It seems that they are not fit to handle anything else then players, which iMO is rather weak.

This message would disapear if you disable the economy feature in Factions. But that would also mean that players don't have to pay/ get rewarded for/from factions.

If I were you, I'd post a request on their github to support non-player accounts such as factions. `

AppleDash commented 8 years ago

I would personally consider it a bug - support for non-player accounts should be added, but at the same time, the same API methods shouldn't be used for both players and non-players.

I'm not going to be stubborn on this issue like some plugin developers would. Can you obtain some information from Factions, asking what an account name for a factions looks like in the code? (Example, is it just the faction name or is it something like faction:factionname, or what?)

AppleDash commented 8 years ago

The latest version now has support for this, @FrostTaco . There is no release yet, but I will be posting one soon as soon as I do a little bit more testing.

AppleDash commented 8 years ago

Considering this closed as support has been added and there have been no further complaints.