search

AppleDash / SaneEconomy

Finally, a sane economy plugin for Bukkit.
https://www.spigotmc.org/resources/saneeconomy-simple-but-featureful-economy.26223/
GNU General Public License v3.0
19 stars 24 forks source link

Project cleanup, various fixes, enhance the server sync feature #58

Closed sgdc3 closed 6 years ago

AppleDash commented 6 years ago

Thank you very much for your work. I'll review it tonight.

AppleDash commented 6 years ago

I can't take it as it is, but I've gone through the first commit and added the parts I enjoy. What does the second commit re: custom number locale do, exactly? Will this fix the 1000$ reset bug?

sgdc3 commented 6 years ago

I hope it does xD

sgdc3 commented 6 years ago

I can't take it as it is

why? I spent hours clening up the maven structure to make it clean, also you missed the section sync feature, that makes this plugin nice for large networks.

AppleDash commented 6 years ago

Because I like it how it is - I never asked anyone to do that & all it does is make it harder for me to understand while adding no functionality improvement.

I don't know what feature I missed - I am still waiting for an explanation for the second commit before I look too hard at it.

AppleDash commented 6 years ago

Also, your PR introduces an SQL injection vulnerability.

sgdc3 commented 6 years ago

@AppleDash i know, i forgot to add the prepared statement variable