search

AppleDash / SaneEconomy

Finally, a sane economy plugin for Bukkit.
https://www.spigotmc.org/resources/saneeconomy-simple-but-featureful-economy.26223/
GNU General Public License v3.0
19 stars 24 forks source link

Strange money duplication from pay command #97

Open jdkeke142 opened 4 years ago

jdkeke142 commented 4 years ago

Some of my players ended up with their money duplicated just from the /pay command and unintentionally.

Maybe it's the multiserver option that doesn't work? Since I enabled it because I have multiple servers with the goal of having shared economy, and I have noticed from a /pay that it doesn't seems to works.

I use the latest version of the plugin from github, built myself.

AppleDash commented 4 years ago

Can you give me a more detailed situation in which this bug occurs? eg: Player info, balances, what servers they were on, what commands were run, configuration, etc.

jdkeke142 commented 4 years ago

The pay to a player on another server of the bungeecord will produce this error on the receiver server: https://gist.github.com/jdkeke142/ce500179f193f2b8882c8473eeaebee4

My config file looks like this: https://gist.github.com/jdkeke142/f78505ef970edc938c6547818aa10895

About the setup, all servers share same configuration and are on the same database for SaneEconomy.

I was unable to reproduce the problem, but as I said, I'm pretty sure it's related to the pay command. We've seen players for whom the balance has literally doubled after a /pay command.

And as I said the second problem is that the update of the balance after a /pay or any transaction commands across servers does not take place, the player must change server, so basically disconnecting bukkit-wise.

I'm pretty sure the second problem is directly related to the fact that the bungee message is not handled properly on the receiver server,

Thanks for future help.

Update: It also seems to work the other way around sometimes, I have players who paid another player, they lost their money, but the receiver only got part of the first transaction and didn't get the second transaction at all.

AppleDash commented 4 years ago

Hmm, that is interesting... Anything on the originating server? I'm looking at the code and everything seems fine.

On Fri, Mar 27, 2020 at 9:28 PM Kévin Jimenez notifications@github.com wrote:

The pay to a player on another server of the network will produce this error on the receiver server: https://gist.github.com/jdkeke142/ce500179f193f2b8882c8473eeaebee4

My config file looks like this: https://gist.github.com/jdkeke142/f78505ef970edc938c6547818aa10895

About the setup, all servers are on the same database for the plugin.

I was unable to reproduce the problem, but as I said, I'm pretty sure it's related to the pay command. We've seen players for whom the balance has literally doubled after a /pay command.

And as I said the second problem is that the update of the balance after a /pay or any transaction commands across servers does not take place, the player must change server, so basically disconnecting bukkit-wise.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/AppleDash/SaneEconomy/issues/97#issuecomment-605322897, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOZSLMLETMGXLEJWW7CHTDRJULBVANCNFSM4LU52VSQ .

jdkeke142 commented 4 years ago

No errors on the source server