search

Applied-GeoSolutions / gips

Geospatial Image Processing System
GNU General Public License v3.0
17 stars 5 forks source link

DH needs support for product arguments #333

Open ra-tolson opened 7 years ago

ra-tolson commented 7 years ago

Some drivers (mostly landsat and sentinel2 apparently) specify products with hyphen-delimited strings:

$ gips_process sentinel2 -p ref-toa # makes TOA reflectance
$ gips_process sentinel2 -p ref # surface reflectance

To be viable the datahandler needs to support this somehow; presently it only supports products with no arguments, eg 'ref' but not 'ref-toa'.

Alternatively, revise gips so that there's no such thing as products with arguments, as it's a hacked-in feature that's not often used, seemingly, and doesn't let us do anything we can't do with plain products. And since the _products dicts can be specified programmatically, it's actually much simpler to just do away with parameterization altogether:

https://github.com/Applied-GeoSolutions/gips/blob/09c9d2389a1130264afdd26577867529979def9f/gips/data/sentinel2/sentinel2.py#L618

bhbraswell commented 7 years ago

Does Sentinel-2 really need the "proto-product" concept? We've tackled this in other ways before.