search

Applied-GeoSolutions / gips

Geospatial Image Processing System
GNU General Public License v3.0
17 stars 5 forks source link

issue 8 backfill part 2 of 2 #337

Closed ra-tolson closed 7 years ago

ra-tolson commented 7 years ago

The rest of the items marked for fixing from #8 have been fixed; this PR now resolves #8, hopefully.

In some cases I second-guessed my original comment about what to do; some cases seemed not to warrant error-handling at all, for instance if the code is known to be inside another error handler already. A few cases seemed to dissolve with refactoring, too. Also decided to patch in the thing from #201 for weld.

I believe I've executed all this code, even the thing in algorithm.py by importing and calling main() directly.

ra-tolson commented 7 years ago

PS just to avoid losing track of it, took care of this comment from #8:

https://github.com/Applied-GeoSolutions/gips/issues/8#issuecomment-314849195

ra-tolson commented 7 years ago

Since this hadn't merged yet I added fixes for atmosphere.py and sarannual.py.

Former was tested by sentinel2 and landsat atmo-corrected processing, latter was tested by gips_process sarannual once I stole some assets from the company store.

ra-tolson commented 7 years ago

Added an aod commit, so now issue 8 is ready to close when this PR merges:

$ grep -r 'TODO error' gips || echo all done!
all done!

AOD changes were tested by running gips_process sentinel2 -p ref -v6; one of the with-blocks isn't entered unless a conditional in get_aod is entered, so I forced it by temporarily hardcoding the value.