392 acolite for s2 - Githubissues

Applied-GeoSolutions / gips

Geospatial Image Processing System

GNU General Public License v3.0

17 stars 5 forks source link

392 acolite for s2 #397

Closed ra-tolson closed 7 years ago

ra-tolson commented 7 years ago

moved the product dicts to gips.atmosphere to reduce boilerplate.
two internal assumptions about landsat in the acolite processing function were turned into arguments, so s2 could call it in an s2 way
it ran over time budget so I didn't add an acolite test for sentinel-2, can do that presently if it's needed

ircwaves commented 7 years ago

Quick eyeball looks good. Please add S2 ACOLITE system test, and rectify branch conflicts.

ra-tolson commented 7 years ago

I attempted to generate checksums for the acolite sentinel-2 system test, but then this happened:

>               self.hash = zlib.crc32(fp.read())
E               OverflowError: size does not fit in an int

It makes sense; I believe the sentinel-2 rhow product is unusually large, something like 2.1G. The crc32 call is in the scripttest library; I'd have to violate the moratorium on improving the system test harness, I think, to fix it.

ra-tolson commented 7 years ago

ps this has a fix for #390 too

ra-tolson commented 7 years ago

Landsat and Sentinel-2 acolite products can be found under /scratch/tolson/pub/gips-issue-392/. Landsat has products generated with the dev branch and with this feature branch, but their md5sums are the same so I guess not much to do there.