Applied-GeoSolutions / gips

Geospatial Image Processing System
GNU General Public License v3.0
17 stars 5 forks source link

Handle subprocesses consistently #426

Open ra-tolson opened 6 years ago

ra-tolson commented 6 years ago

gips uses two or three ways to call subprocesses, and the handling isn't consistent. Write a subprocess handler that does things in a unifed way almost like we have for error handling. Stuff we could do in the handler for consistency:

For the initial implementation, these basic features should be sufficient, plus a few conversions of existing code like we did for error handling. Then future iterations can convert all the subprocesses in gips, and improve the implementation as we see fit.

ra-tolson commented 6 years ago

Regarding which lib to use, commands has a deprecation warning, and a claim about subprocess having better features; subprocess says you should use the backported version from python3:

https://pypi.python.org/pypi/subprocess32/