Applied-GeoSolutions / gips

Geospatial Image Processing System
GNU General Public License v3.0
17 stars 5 forks source link

510 port sentinel-2 processing to python 3 + gippy 1.0 #512

Closed ra-tolson closed 4 years ago

ra-tolson commented 4 years ago

Note this PR is aimed at the other py3-port branch so that we can use it as the shared dev branch for this effort.

Restored the ref & rad system tests since it was clear they needed revision. Used --overwrite to work around the sentinel-2 sensitivity to whether those products exist when generating derivative products.

Mostly, outputs drifted by a little for unknown reasons. The known exception is crcm:

-     '  Minimum=-8561.000, Maximum=32767.000, Mean=2954.280, StdDev=3506.046',
+     '  Minimum=-8624.000, Maximum=32767.000, Mean=2395.565, StdDev=3341.763',

However, the image & histogram looked a lot like the old one, so for now I accepted it (and I'd suggest we merge before getting into any revisions for it since we're not merging into dev -- we can afford to be a little looser with the usual rules).