search

AppliedEnergistics / Applied-Energistics-2

A Minecraft Mod about Matter, Energy and using them to conquer the world..
https://appliedenergistics.github.io/
Other
1.44k stars 661 forks source link

Skystone not in ore dictionary #337

Closed zrootz closed 10 years ago

zrootz commented 10 years ago

Why skystone is not in forge ore dictionary? can you add it?

thatsIch commented 10 years ago

ore=ae2:BlockSkyStone:1 -> skystone should do the trick or maybe stoneSky?.

zrootz commented 10 years ago

Sorry, that's a line of code i must add somewhere? i'm not a programmer, i just know skystone is not in ore dictionary because when i use the mekanism dictionary in skystone says "no data".

thatsIch commented 10 years ago

In the AE2 recipe files if you use customized recipes. Generally we dont want to pollute the OreDictionary but if another mod wants to add mod support for that specific item and via the OreDictionary it is very easy to handle it but generally not the preferred way. (A reason why crafting with ExtraBees can take a very long time [many oredictionaried bees])

zrootz commented 10 years ago

Other mods machines like for example MFR laser drill needs the ore be by default in the ore dictionary in order to use it. I don't really understand very much that "dont want to pollute" argument but anyway now i have learn something else about AE2, didn't know that "customized recipes" feature. If i modify the recipe file, put the modified file back in the jar file and disable the "customized recipes" feature it will still working?

thatsIch commented 10 years ago

sure, but then you would need to update the jar every time. Its easier to recycle the custom recipe by letting it stay in your config folder. Skystone is not an ore, MFR Laserdrill would make no sense for Skstone (since it diggs through the underground layer to bring forth more ores). Skystone, based on its name, comes from the sky in form of meteorites.

And by polluting, I mean, that you need to look up every possible entry to check if the dictionary contains it. Imagine a telephonebook with 100 people. Its obviously easier to look up than a book with 100000 people.

zrootz commented 10 years ago

Didn't worked, i putted that line in .minecraft/config/AppliedEnergistics2/index.recipe, then changed to that B:CustomRecipes=true in .minecraft/config/AppliedEnergistics2/AppliedEnergistics2.cfg but when i click with the ore disctionary in skystone keeps saying "no data". I have the game in another languaje, can be the name translation the problem?

Probably laser drill was not the best example but some machines from other mods use the ore dictionary like mekanism logistical sorters or seismic reader and other machines i don't remember now. I understand the "polluting" word, what i don't understand is you consider "polluting" adding a single ore to the ore dictionary while other mods adds dozens of them. Finally, you say skystone is not an ore because is suppusedly coming from the sky. Well is just a matter of the definition of what is and "ore" and what not. For me the definition is very clear, every solid block you can find and pick in worldgen (letting appart special structures like villages or mines) and is not renewable is an ore (notice that stone, sand and dirt are renewable resources and you can't pick bedrock). For example, packed ice is a non-renewable resource and not very common. Is not easy to find, can be harder to find than diamond, although when you find it there are huge amounts of it all together, can be considered an ore.

Cisien commented 10 years ago

We're not going to add skystone to the ore dictionary because ae2 has no need to it to be there.

Additionally as @thatsIch pointed out, ae2 already lets modpack designers or normal users with the ability to go in the config and enable it.

thatsIch commented 10 years ago

Config: Where do you look it up? I have no idea where you can easily check the oredictionary like that. Translation is not an issue, because the oredictionary has no localization. Post both files and your fml log or just join IRC which is better suited for that.

Pollution: And now add 100 mods who only add 1 single block to the oredictionary and we are already at 100. Anybody can prevent pollution, like in real life. We only add it on request by other mod authors. Else there is no point, for end-users there are stuff like custom recipes or even MineTweaker/ModTweaker, when they want to do that.

Ore: I meant it in a semantic way with the skystone in relation to the laser drill. OreDictionary is by long not used anymore for ores and the definition of renewable has problems, because this depends on the mods and functionality you install.