Performance issues on Terminal if Craftable only view is active

jkroepke commented 6 years ago

Description

Using the ME Network on a Terminal work fine. But If I search for an item and set the view to craftable only. The client will start to lag and after 30 seconds the client ll be kicked from the server.

Switch back View items only or hybrid view brings the client performance back.

Screen from VisualVM

The performance comes not from AE2 directly, it looks for me that Biomes O' Plenty are the reason for that.

I'm want to report this issue here, because behavior isn't constant. It appears only an the "craftable only" - not on the Stored Item or Stored Item / Craftable View

Environment

Multiplayer

Large ME Network

| State | ID                       | Version                  | Source                                              | Signature                                |
|:----- |:------------------------ |:------------------------ |:--------------------------------------------------- |:---------------------------------------- |
|       | minecraft                | 1.12.2                   | minecraft.jar                                       | None                                     |
|       | mcp                      | 9.42                     | minecraft.jar                                       | None                                     |
|       | FML                      | 8.0.99.99                | forge-1.12.2-14.23.2.2611-universal.jar             | e3c3d50c7c986df74c645c0ac54639741c90a557 |
|       | forge                    | 14.23.2.2611             | forge-1.12.2-14.23.2.2611-universal.jar             | e3c3d50c7c986df74c645c0ac54639741c90a557 |
|       | ivtoolkit                | 1.3.3-1.12               | minecraft.jar                                       | None                                     |
|       | mtqfix                   | 1.1.0                    | minecraft.jar                                       | None                                     |
|       | solarfluxreborncore      | 3.42r                    | minecraft.jar                                       | None                                     |
|       | foamfixcore              | 7.7.4                    | minecraft.jar                                       | None                                     |
|       | woodconverter            | v2.9.2                   | [1.12]WoodConverter v2.9.2.jar                      | None                                     |
|       | acintegration            | 1.6.2                    | AbyssalCraft Integration-1.12.2-1.6.2.jar           | None                                     |
|       | abyssalcraft             | 1.9.4.4                  | AbyssalCraft-1.12.2-1.9.4.4.jar                     | None                                     |
|       | ae2stuff                 | 0.7.0.4                  | ae2stuff-0.7.0.4-mc1.12.2.jar                       | None                                     |
|       | angelringforbauble       | 1.0.0                    | angelringforbauble-12.21.0.0.jar                    | None                                     |
|       | applecore                | 3.1.0                    | AppleCore-mc1.12.2-3.1.0.jar                        | None                                     |
|       | appleskin                | 1.0.9                    | AppleSkin-mc1.12-1.0.9.jar                          | None                                     |
|       | appliedenergistics2      | rv5-stable-7             | appliedenergistics2-rv5-stable-7.jar                | None                                     |
|       | aroma1997core            | 2.0.0.0.b144             | Aroma1997Core-1.12.2-2.0.0.0.b144.jar               | None                                     |
|       | aroma1997sdimension      | 2.0.0.2.b65              | Aroma1997s-Dimensional-World-1.12.2-2.0.0.2.b65.jar | None                                     |
|       | avaritia                 | 3.2.0                    | Avaritia-1.12-3.2.0.13-universal.jar                | None                                     |
|       | avaritiatweaks           | 1.12.2-1.1               | AvaritiaTweaks-1.12.2-1.1.jar                       | None                                     |
|       | base                     | 3.6.1                    | base-1.12.2-3.6.1.jar                               | None                                     |
|       | baubles                  | 1.5.2                    | Baubles-1.12-1.5.2.jar                              | None                                     |
|       | bdlib                    | 1.14.3.12                | bdlib-1.14.3.12-mc1.12.2.jar                        | None                                     |
|       | bedbugs                  | @VERSION@                | BedBugs-1.12-1.0.1.jar                              | None                                     |
|       | bettermuffling           | 0.2.0-Beta               | Better+Muffling-1.12.2-0.2.0-Beta.jar               | None                                     |
|       | betterbedrockgen         | 6.0.2                    | BetterBedrockGenerator-1.12-6.1.1.jar               | None                                     |
|       | bibliocraft              | 2.4.3                    | BiblioCraft[v2.4.3][MC1.12.0].jar                   | None                                     |
|       | bibliotheca              | 1.2.2-1.12.2             | bibliotheca-1.2.2-1.12.2.jar                        | None                                     |
|       | binniecore               | unspecified              | binnie-mods-1.12.2-2.5.0.112.jar                    | None                                     |
|       | botany                   | 2.5.0.112                | binnie-mods-1.12.2-2.5.0.112.jar                    | None                                     |
|       | binniedesign             | 1.0                      | binnie-mods-1.12.2-2.5.0.112.jar                    | None                                     |
|       | extrabees                | 2.5.0.112                | binnie-mods-1.12.2-2.5.0.112.jar                    | None                                     |
|       | extratrees               | 2.5.0.112                | binnie-mods-1.12.2-2.5.0.112.jar                    | None                                     |
|       | genetics                 | 2.5.0.112                | binnie-mods-1.12.2-2.5.0.112.jar                    | None                                     |
|       | biomesoplenty            | 7.0.1.2322               | BiomesOPlenty-1.12.2-7.0.1.2322-universal.jar       | None                                     |
|       | bloodmagic               | 1.12.2-2.2.7-90          | BloodMagic-1.12.2-2.2.7-90.jar                      | None                                     |
|       | bookshelf                | 2.3.528                  | Bookshelf-1.12.2-2.3.528.jar                        | None                                     |
|       | brandonscore             | 2.4.0                    | BrandonsCore-1.12-2.4.0.152-universal.jar           | None                                     |
|       | capabilityproxy          | 2.1.1                    | CapabilityProxy-1.12.2-2.1.1.jar                    | None                                     |
|       | chesttransporter         | 2.8.7                    | ChestTransporter-1.12-2.8.7.jar                     | None                                     |
|       | chickenchunks            | 2.4.1.71                 | ChickenChunks-1.12.2-2.4.1.71-universal.jar         | None                                     |
|       | chisel                   | MC1.12-0.1.1.28          | Chisel-MC1.12-0.1.1.28.jar                          | None                                     |
|       | clumps                   | 2.0.0                    | Clumps-3.0.0.jar                                    | None                                     |
|       | codechickenlib           | 3.1.5.331                | CodeChickenLib-1.12.2-3.1.5.331-universal.jar       | None                                     |
|       | cofhcore                 | 4.3.10                   | CoFHCore-1.12.2-4.3.10.5-universal.jar              | None                                     |
|       | cofhworld                | 1.1.1                    | CoFHWorld-1.12.2-1.1.1.12-universal.jar             | None                                     |
|       | comforts                 | 1.1.0.2                  | comforts-1.12.2-1.1.0.2.jar                         | None                                     |
|       | commoncapabilities       | 1.4.0                    | CommonCapabilities-1.12-1.4.0.jar                   | None                                     |
|       | cookingforblockheads     | 6.3.17                   | CookingForBlockheads_1.12.1-6.3.17.jar              | None                                     |
|       | craftingtweaks           | 8.1.6                    | CraftingTweaks_1.12.1-8.1.6.jar                     | None                                     |
|       | csokicraftutil           | 1.3.1                    | CsokiCraftUtil-1.3.6.jar                            | None                                     |
|       | csokicraftutil-11        | 1.3.1                    | CsokiCraftUtil-1.3.6.jar                            | None                                     |
|       | cyberware                | 0.2.10.9                 | cyberware-1.12.2-0.2.10.9.jar                       | None                                     |
|       | cyclicmagic              | 1.13.3                   | Cyclic-1.12.2-1.13.3.jar                            | None                                     |
|       | cyclopscore              | 0.11.4                   | CyclopsCore-1.12.2-0.11.4.jar                       | None                                     |
|       | darkutils                | 1.8.193                  | DarkUtils-1.12.2-1.8.193.jar                        | None                                     |
|       | debugserverinfo          | 1.0.5                    | DebugServerInfo-1.12.2-1.0.5.jar                    | None                                     |
|       | ptrmodellib              | 1.0.0                    | Decocraft-2.5.4_1.12.2.jar                          | None                                     |
|       | props                    | 2.5.4                    | Decocraft-2.5.4_1.12.2.jar                          | None                                     |
|       | dirt2path                | 1.7.0                    | dirt2path-1.7.0.jar                                 | None                                     |
|       | discordintegration       | 3.0.4                    | DiscordIntegration-mc1.12.2-3.0.4.jar               | None                                     |
|       | draconicevolution        | 2.3.10                   | Draconic-Evolution-1.12-2.3.10.284-universal.jar    | None                                     |
|       | dsurround                | 3.4.9.4                  | DynamicSurroundings-1.12.2-3.4.9.4.jar              | None                                     |
|       | dynmap                   | 3.0-alpha-1-11           | Dynmap-3.0-alpha-1-forge-1.12.2.jar                 | None                                     |
|       | dynmapblockscan          | 3.0-alpha-1-5            | DynmapBlockScan-3.0-alpha-1-forge-1.12.2.jar        | None                                     |
|       | enderstorage             | 2.4.2.126                | EnderStorage-1.12.2-2.4.2.126-universal.jar         | None                                     |
|       | engineersworkshop        | 1.4.0-1.12.2             | EngineersWorkshop-1.4.0-1.12.2.jar                  | None                                     |
|       | environmentaltech        | 1.12.2-2.0.7b            | environmentaltech-1.12.2-2.0.7b.jar                 | None                                     |
|       | etlunar                  | 1.12.2-2.0.7a            | etlunar-1.12.2-2.0.7a.jar                           | None                                     |
|       | extracells               | 2.5.11                   | ExtraCells-1.12.2-2.5.11a48.jar                     | None                                     |
|       | extrautils2              | 1.0                      | extrautils2-1.12-1.7.4.jar                          | None                                     |
|       | bigreactors              | 1.12.2-0.4.5.46          | ExtremeReactors-1.12.2-0.4.5.46.jar                 | None                                     |
|       | farmingforblockheads     | 3.1.5                    | FarmingForBlockheads_1.12-3.1.5.jar                 | None                                     |
|       | fluxnetworks             | 3.0.4                    | fluxnetworks-1.12.2-3.0.4.jar                       | None                                     |
|       | foamfix                  | 0.9.4-1.12.2             | foamfix-0.9.4-1.12.2-anarchy.jar                    | None                                     |
|       | forestry                 | 5.8.0.250                | forestry_1.12.2-5.8.0.250.jar                       | None                                     |
|       | forgelin                 | 1.6.0                    | Forgelin-1.6.0.jar                                  | None                                     |
|       | funkylocomotion          | 1.0                      | funky-locomotion-1.12.2-1.1.0.jar                   | None                                     |
|       | gendustry                | 1.6.5.8                  | gendustry-1.6.5.8-mc1.12.2.jar                      | None                                     |
|       | globalxp                 | v1.4                     | globalxp-1.12.x-v1.4.jar                            | None                                     |
|       | gravestone               | 1.10.1                   | gravestone-1.10.1.jar                               | None                                     |
|       | guideapi                 | 1.12-2.1.4-57            | Guide-API-1.12-2.1.4-57.jar                         | None                                     |
|       | hammercore               | 1.9.6.5                  | HammerCore-1.12.2-1.9.6.5.jar                       | None                                     |
|       | hats                     | 7.0.0                    | Hats-1.12.2-7.0.2.jar                               | None                                     |
|       | hungeroverhaul           | 1.12.2-1.3.1.jenkins144  | HungerOverhaul-1.12.2-1.3.1.jenkins144.jar          | None                                     |
|       | waila                    | 1.8.23                   | Hwyla-1.8.23-B38_1.12.jar                           | None                                     |
|       | ichunutil                | 7.1.4                    | iChunUtil-1.12.2-7.1.4.jar                          | None                                     |
|       | industrialforegoing      | 1.12.2-1.12.2            | industrialforegoing-1.12.2-1.8.2-121.jar            | None                                     |
|       | instantunify             | 1.1.1                    | instantunify-1.12.2-1.1.1.jar                       | None                                     |
|       | integrateddynamics       | 0.11.4                   | IntegratedDynamics-1.12.2-0.11.4.jar                | None                                     |
|       | integrateddynamicscompat | 1.0.0                    | IntegratedDynamics-1.12.2-0.11.4.jar                | None                                     |
|       | integratedtunnels        | 1.5.2                    | IntegratedTunnels-1.12.2-1.5.2.jar                  | None                                     |
|       | integratedtunnelscompat  | 1.0.0                    | IntegratedTunnels-1.12.2-1.5.2.jar                  | None                                     |
|       | integrationforegoing     | 1.12-1.5                 | IntegrationForegoing-1.12.2-1.5.jar                 | None                                     |
|       | inventorytweaks          | 1.63+release.109.220f184 | InventoryTweaks-1.63.jar                            | None                                     |
|       | ironbackpacks            | 1.12.2-3.0.5-6           | IronBackpacks-1.12.2-3.0.5-6.jar                    | None                                     |
|       | ironchest                | 1.12.2-7.0.40.824        | ironchest-1.12.2-7.0.40.824.jar                     | None                                     |
|       | jaopca                   | 1.12.2-2.2.6.74          | JAOPCA-1.12.2-2.2.6.74.jar                          | None                                     |
|       | oredictinit              | 1.12.2-2.2.1.67          | JAOPCA-1.12.2-2.2.6.74.jar                          | None                                     |
|       | jehc                     | 1.3.1                    | jehc-1.12-1.3.1.jar                                 | None                                     |
|       | jei                      | 4.8.5.159                | jei_1.12.2-4.8.5.159.jar                            | None                                     |
|       | jeibees                  | 0.9.0.5                  | jeibees-0.9.0.5-mc1.12.2.jar                        | None                                     |
|       | journeymap               | 1.12.2-5.5.2             | journeymap-1.12.2-5.5.2.jar                         | None                                     |
|       | kleeslabs                | 5.3.2                    | KleeSlabs_1.12-5.3.2.jar                            | None                                     |
|       | laggoggles               | FORGE-1.12.2-4.0         | LagGoggles-FORGE-1.12.2-4.0.jar                     | None                                     |
|       | laggoggles               | FORGE-1.12.2-4.1         | LagGoggles-FORGE-1.12.2-4.1.jar                     | None                                     |
|       | login_shield             | 1.12.2-1-g24c2a5e        | Login_Shield-1.12.2-1-g24c2a5e.jar                  | None                                     |
|       | magicbees                | 1.0                      | MagicBees-1.12.2-3.1.9.jar                          | None                                     |
|       | malisiscore              | 1.12.2-6.4.0             | malisiscore-1.12.2-6.4.0.jar                        | None                                     |
|       | malisisdoors             | 1.12.2-7.3.0             | malisisdoors-1.12.2-7.3.0.jar                       | None                                     |
|       | malisisswitches          | 1.12.2-5.1.0             | malisisswitches-1.12.2-5.1.0.jar                    | None                                     |
|       | mantle                   | 1.12-1.3.1.21            | Mantle-1.12-1.3.1.21.jar                            | None                                     |
|       | mcmultipart              | 2.4.1                    | MCMultiPart-2.4.1.jar                               | None                                     |
|       | mekanism                 | 1.12.2-9.4.3.330         | Mekanism-1.12.2-9.4.3.330.jar                       | None                                     |
|       | mekanismgenerators       | 9.4.3                    | MekanismGenerators-1.12.2-9.4.3.330.jar             | None                                     |
|       | mekanismtools            | 9.4.3                    | MekanismTools-1.12.2-9.4.3.330.jar                  | None                                     |
|       | mercurius_updater        | 1.0                      | MercuriusUpdater-1.12.2.jar                         | None                                     |
|       | testdummy                | 1.12                     | MmmMmmMmmMmm-1.12-1.14.jar                          | None                                     |
|       | mob_grinding_utils       | 0.3.4                    | MobGrindingUtils-0.3.4.jar                          | None                                     |
|       | morebees                 | 1.12.2-1.4.4             | morebees-1.12.2-1.4.4.jar                           | None                                     |
|       | morpheus                 | 1.12-3.3.2               | Morpheus-1.12-3.3.2.jar                             | None                                     |
|       | netherportalfix          | 5.3.13                   | NetherPortalFix_1.12.1-5.3.13.jar                   | None                                     |
|       | noendermanpickup         | 1.2                      | noep-1.2.jar                                        | None                                     |
|       | nmsot                    | 1.2.1-mc1.12             | NoMobSpawningOnTrees-1.2.1-mc1.12.jar               | None                                     |
|       | nei                      | 2.4.1                    | NotEnoughItems-1.12.2-2.4.1.233-universal.jar       | None                                     |
|       | p455w0rdslib             | 2.0.28                   | p455w0rdslib-1.12-2.0.28.jar                        | None                                     |
|       | harvestcraft             | 1.12.2q                  | Pam's+HarvestCraft+1.12.2q.jar                      | None                                     |
|       | plustic                  | 6.3.6.2                  | plustic-6.3.6.2.jar                                 | None                                     |
|       | prefab                   | 1.3.0.16                 | prefab-1.3.0.16.jar                                 | None                                     |
|       | quantumstorage           | 4.4.8                    | QuantumStorage-1.12-4.4.8.jar                       | None                                     |
|       | quickhomes               | 1.2                      | QuickHomes-1.2.jar                                  | None                                     |
|       | quickleafdecay           | 1.2.4                    | QuickLeafDecay-MC1.12.1-1.2.4.jar                   | None                                     |
|       | randomthings             | 4.1.3                    | RandomThings-MC1.12.2-4.1.3.jar                     | None                                     |
|       | reborncore               | 3.6.7.210                | RebornCore-1.12.2-3.6.7.210-universal.jar           | None                                     |
|       | reccomplex               | 1.4.6                    | RecurrentComplex-1.4.6.jar                          | None                                     |
|       | redstoneflux             | 2.0.1                    | RedstoneFlux-1.12-2.0.1.2-universal.jar             | None                                     |
|       | roguelike                | 1.8.0                    | RoguelikeDungeons-1.12.2-1.8.0.jar                  | None                                     |
|       | signal-catcher           | 1.1                      | signalcatcher-1.1.jar                               | None                                     |
|       | simplequarry             | 10r                      | SimpleQuarry_1.12.2-10r.jar                         | None                                     |
|       | solarfluxreborn          | 3.42r                    | SolarFluxReborn_1.12.2-3.42r.jar                    | None                                     |
|       | sonarcore                | 5.0.6                    | sonarcore-1.12.2-5.0.6.jar                          | None                                     |
|       | spiceoflife              | 1.3.11                   | SpiceOfLife-mc1.12-1.3.11.jar                       | None                                     |
|       | stevescarts              | 2.4.17.88                | StevesCarts-1.12.2-2.4.17.88.jar                    | None                                     |
|       | tconstruct               | 1.12.2-2.9.1.65          | TConstruct-1.12.2-2.9.1.65.jar                      | None                                     |
|       | tesla                    | 1.0.60                   | Tesla-1.12-1.0.60.jar                               | None                                     |
|       | teslacorelib             | 1.0.13                   | tesla-core-lib-1.12-1.0.13.jar                      | None                                     |
|       | teslacorelib_registries  | 1.0.13                   | tesla-core-lib-1.12-1.0.13.jar                      | None                                     |
|       | thermalcultivation       | 0.1.5                    | ThermalCultivation-1.12.2-0.1.5.3-universal.jar     | None                                     |
|       | thermaldynamics          | 2.3.10                   | ThermalDynamics-1.12.2-2.3.10.4-universal.jar       | None                                     |
|       | thermalexpansion         | 5.3.10                   | ThermalExpansion-1.12.2-5.3.10.15-universal.jar     | None                                     |
|       | thermalfoundation        | 2.3.10                   | ThermalFoundation-1.12.2-2.3.10.6-universal.jar     | None                                     |
|       | tickprofiler             | 1.12-0.0.4               | TickProfiler-1.12-0.0.4.jar                         | None                                     |
|       | tinkegration             | 0.1.1                    | tinkegration-0.1.1.jar                              | None                                     |
|       | tinkersaddons            | 1.0.7                    | Tinkers' Addons-1.12.1-1.0.7.jar                    | None                                     |
|       | tinkertoolleveling       | 1.12-1.0.3.DEV.56fac4f   | TinkerToolLeveling-1.12-1.0.3.jar                   | None                                     |
|       | treechopper              | 1.2.4                    | TreeChopper-1.12.2-1.2.4.jar                        | None                                     |
|       | twilightforest           | 3.6.345                  | twilightforest-1.12.2-3.6.345-universal.jar         | None                                     |
|       | unidict                  | 1.12.2-2.3.3             | UniDict-1.12.2-2.3.3.jar                            | None                                     |
|       | usefulnullifiers         | 1.4.1                    | usefulnullifiers-1.4.1.jar                          | None                                     |
|       | valkyrielib              | 1.12.2-2.0.6b            | valkyrielib-1.12.2-2.0.7a.jar                       | None                                     |
|       | wanionlib                | 1.12.2-1.5               | WanionLib-1.12.2-1.5.jar                            | None                                     |
|       | wawla                    | 2.5.251                  | Wawla-1.12.2-2.5.251.jar                            | None                                     |
|       | whitelistsync            | 1.1-1.12.2               | whitelistsync-1.1-1.12.2.jar                        | None                                     |
|       | wct                      | 3.9.59                   | WirelessCraftingTerminal-1.12.2-3.9.59.jar          | None                                     |
|       | woot                     | 1.12.2-1.0.0             | woot-1.12.2-1.0.0.jar                               | None                                     |
|       | wrapup                   | 1.12-1.1.3               | WrapUp-1.12-1.1.3.jar                               | None                                     |
|       | xnet                     | 1.6.7                    | xnet-1.12-1.6.7.jar                                 | None                                     |
|       | ynot                     | 0.2.2                    | YNot-0.2.2.jar                                      | None                                     |
|       | zerocore                 | 1.12-0.1.1.0             | zerocore-1.12-0.1.1.0.jar                           | None                                     |

Minecraft Version: 1.12.2
AE2 Version: RV5 Stable 7
Forge Version: 14.23.2.1611

yueh commented 6 years ago

In terms of consistency, it should only happen when these conditions are true:

set to Craftable view (just to mention it again)
config SEARCH_TOOLTIPS set to YES
filter not empty
filter no searching for a mod (starting with @)

By default we already cache the tooltips for something like that, but it is not done for the craftable only view currently as we cannot touch the underlying itemstack data. So it will be copied, which will not copy the cached tooltip for obvious reasons like memory usage. So it has to fetch it for every update again, but this only happens when the network inventory changes.

We might be able to ease it a bit. BUT this should not solve the actual issue. Which certainly needs further monitoring and should also be reported to any involved mod. E.g. it could actually be caused by JEIIntegration combined with Biomes O' Plenty. Any other mod with a more trivial approach for using tooltips could easily suffer from it.

Edit: Depending on the mentioned mods, it might also only happen when the advanced tooltips are enabled via F3 + H

jkroepke commented 6 years ago

Edit: Depending on the mentioned mods, it might also only happen when the advanced tooltips are enabled via F3 + H

I'll test it but in our setup it doesn't matter.

yueh commented 6 years ago

Yeah. That was just a guess, hoping that the mod extending the tooltips is smart enough to only enable it when the advanced option is enabled.

Could you try this build? It is not perfect, as displaying the tooltip will still resolve it a second time. But at least the search should mostly run against a cached version.

jkroepke commented 6 years ago

Can you provide a build with an beta version? I have mods installed that require a rv5-beta

Missing Mods:
    appliedenergistics2 : [rv5-beta-1,)

Thanks for the support here.

yueh commented 6 years ago

Not possible with the CI setup and I would also prefer that CI builds do not float around as beta or even stable releases. Best option here would be the branch yourself.

jkroepke commented 6 years ago

I setup a own build based on branch fix-3405.

I'm unable to reproduce it now. Thanks you.

AppliedEnergistics / Applied-Energistics-2

Performance issues on Terminal if Craftable only view is active #3405

Description

Environment