search

AppliedEnergistics / Applied-Energistics-2

A Minecraft Mod about Matter, Energy and using them to conquer the world..
https://appliedenergistics.github.io/
Other
1.44k stars 661 forks source link

Select amount screen issue for fluids #6520

Closed Technici4n closed 9 months ago

Technici4n commented 2 years ago

image

Try to encode water in a pattern in 1.19, press middle mouse.

Technici4n commented 1 year ago

(the problem here is the B overlapping with the Set button)

tommyrhayes commented 1 year ago

Hey! I'm a first-time contributor and would like to help work on this issue! Is there anyone working on it currently?

Technici4n commented 1 year ago

No, go ahead! ;)

floridaman commented 1 year ago

@tommyrhayes you still going to look at this one?

@Technici4n also just generate information for whomever is looking at this. Would you prefer to maintain the spacing for the window and just hide the units? Or is maintaining the widget spacing the priority here?

image image
Technici4n commented 1 year ago

My only requirement is that it looks good. Ideally we'd change the length of the text field based on whether it's an item / fluid. Your second picture is good for fluids, for items it would be best to have the full width.

torhayes commented 1 year ago

@tommyrhayes you still going to look at this one?

@Technici4n also just generate information for whomever is looking at this. Would you prefer to maintain the spacing for the window and just hide the units? Or is maintaining the widget spacing the priority here?

image image

Hey! Yeah I plan on working on it this week, have just had some trouble setting up my environment.

floridaman commented 1 year ago

@tommyrhayes excellent! Looks like you have a clear path forward.

torhayes commented 1 year ago

I'm having trouble finding where this file is located in the project directory. Could anyone offer any support?

floridaman commented 1 year ago

I'm having trouble finding where this file is located in the project directory. Could anyone offer any support?

When I was poking at the code earlier to make that demo, I searched for "middle click" since I thought that this functionality was only used in one or two places. But I am sure there are other ways to find it. Another obvious way would be to search for the localization string for "Select Amount". The menus layouts are stored as JSON.

Technici4n commented 1 year ago

Now we have the issue for items again

shartte commented 1 year ago

Oh you wanted the "good" solution? :-P

Technici4n commented 1 year ago

:roll_eyes: