AppliedEnergistics / Applied-Energistics-2

A Minecraft Mod about Matter, Energy and using them to conquer the world..
https://appliedenergistics.github.io/
Other
1.44k stars 662 forks source link

The guide says that ammo weight affects damage, but it only affects weight #7498

Closed ChiefArug closed 11 months ago

ChiefArug commented 11 months ago

The guidebook says that ammo weight affects damage, but that is untrue. It only affects penetration. See code: https://github.com/AppliedEnergistics/Applied-Energistics-2/blob/b271fa33c7efb90211620c3cb940f9c0a64d2b1f/src/main/java/appeng/items/tools/powered/MatterCannonItem.java#L181-L182 https://github.com/AppliedEnergistics/Applied-Energistics-2/blob/b271fa33c7efb90211620c3cb940f9c0a64d2b1f/guidebook/items-blocks-machines/matter_cannon.md?plain=1#L18

Sea-Kerman commented 11 months ago

https://github.com/AppliedEnergistics/Applied-Energistics-2/blob/b271fa33c7efb90211620c3cb940f9c0a64d2b1f/src/main/java/appeng/items/tools/powered/MatterCannonItem.java#L347-L353

https://github.com/AppliedEnergistics/Applied-Energistics-2/blob/b271fa33c7efb90211620c3cb940f9c0a64d2b1f/src/main/java/appeng/items/tools/powered/MatterCannonItem.java#L385-L387

ChiefArug commented 11 months ago

Huh.. I tested this in game with custom ammo (weight of 1000) and that took 20 hits to kill a creeper.

Sea-Kerman commented 11 months ago

If you compare iron and gold you see a large difference. https://github.com/AppliedEnergistics/Applied-Energistics-2/blob/main/src/main/java/appeng/datagen/providers/recipes/MatterCannonAmmoProvider.java

shartte commented 11 months ago

Huh.. I tested this in game with custom ammo (weight of 1000) and that took 20 hits to kill a creeper.

Are you exaggerating with 20 hits? 👀

ChiefArug commented 11 months ago

Are you exaggerating with 20 hits? 👀

Nope, I counted. It may of been an issue with the incredibly custom KubeJS scripts I was using to add the ammo recipe, if the weight fields is optional and defaults to 1 damage. I can check tomorrow.

shartte commented 11 months ago

Which version was it on, anyway?

ChiefArug commented 11 months ago

1.20.1

ChiefArug commented 10 months ago

Tried again today.. and it worked?? No idea why it wasn't working before