search

AppliedEnergistics / Applied-Energistics-2

A Minecraft Mod about Matter, Energy and using them to conquer the world..
https://appliedenergistics.github.io/
Other
1.44k stars 661 forks source link

view cell are still visible on small enough gui scales #7998

Open Mari023 opened 4 months ago

Mari023 commented 4 months ago

image with gui scale 1 on a 1080p screen: 2024-07-01_03 14 14

Mithi83 commented 4 months ago

In 4k gui scale 2 is affected as well.

Mithi83 commented 4 months ago

Isn't the real bug though that the view cell slots are invisible in lower resolutions or with higher gui scale settings? This functionality is not accessible to the player otherwise. From the looks of it the view cells should probably be attached to the right side of the terminal. I played around a bit an setting "right" to "2" instead of "800" in src/main/resources/assets/ae2/screens/terminals/base_terminal.json looks pretty decent unless the scroll bar is shorter than the view cell section height.

@Ridanisaurus probably knows best what the intentions were when he moved that away during retexturing.

Ridanisaurus commented 4 months ago

The ViewCells were moved away temporarily until they are implemented inside the settings page if I recall correctly. I think once that's done they should be removed completely from the BaseScreenGUI. @shartte is better equipped to address this.

Yamijiro commented 2 weeks ago

Isn't there any better solution to this? For the players to have to change their gui scale every time they want to edit their view cells is not optimal to say the least and it's been like this for over 3 months.

Mari023 commented 2 weeks ago

Isn't there any better solution to this? For the players to have to change their gui scale every time they want to edit their view cells is not optimal to say the least and it's been like this for over 3 months.

you can move them using a resource pack, in a comment above it is roughly explained how but the view cells currently being visible at all wasn't really intended

Yamijiro commented 2 weeks ago

you can move them using a resource pack, in a comment above it is roughly explained how but the view cells currently being visible at all wasn't really intended

That works out fine with the cable part terminals, but if you use wireless ones the view cell interface is overlapped by the card upgrade interface. Think the best positioning in this case is at the bottom left, underneath the config buttons for the cards and the terminal itself.

The ViewCells were moved away temporarily until they are implemented inside the settings page if I recall correctly. I think once that's done they should be removed completely from the BaseScreenGUI. @shartte is better equipped to address this.

Until the view cells get implemented into the settings page that is.