search

AppliedEnergistics / Applied-Energistics-2

A Minecraft Mod about Matter, Energy and using them to conquer the world..
https://appliedenergistics.github.io/
Other
1.41k stars 641 forks source link

Missing 0.5px on drive cell models #8017

Closed RuiXuqi closed 1 month ago

RuiXuqi commented 1 month ago

Describe the bug

image image The cell models miss 0.5px.

How to reproduce the bug

Place ME Drive and put any Storage Cells with model update into it

Expected behavior

Fill the gap with leds or cell backdrop

Additional details

No response

Which minecraft version are you using?

1.21

On which mod loaders does it happen?

NeoForge

Crash log

https://pastebin.com/mw9Atr4n

Mithi83 commented 1 month ago

The status LED ist rendered by the code. In the base texture the pixel is black. Since the code only paints over half of the bottom pixel you cannot have that pixel black in the base texture. I've tried to set that pixel to a copy of the top left pixel and that seems to work.

I can make a PR for that, but I'd like to hear @Ridanisaurus opinion first as I'm not an artist.

Mithi83 commented 1 month ago

This also applies to other mods, such as https://raw.githubusercontent.com/AppliedEnergistics/Applied-Mekanistics/794907e2857f4c6b8148ce84d594bb4fb3a1bfa1/src/main/resources/assets/appmek/textures/block/drive/drive_cells.png