search

AppliedEnergistics / Applied-Energistics-2

A Minecraft Mod about Matter, Energy and using them to conquer the world..
https://appliedenergistics.github.io/
Other
1.42k stars 649 forks source link

Missing Translation for Matter Cannon Death Message #8046

Closed TywrapStudios closed 1 month ago

TywrapStudios commented 2 months ago

Describe the bug

When someone on a Multiplayer server is killed using a Matter Cannon simply death.attack.matter_cannon is displayed in chat.

How to reproduce the bug

  1. Get a matter cannon and load it.
  2. Kill another player with it.
  3. Watch chat say death.attack.matter_cannon

Expected behavior

Some translation file entry to make it not say death.attack.matter_cannon but for instance {player} was killed by {player} using a matter cannon.

Additional details

  1. This is on a multiplayer server.
  2. We are on an outdated version of the mod, but checking your source code for the other versions of the mod on our Version and Modloader I couldn't see a lang file entry for this either way. So I think it shouldn't be impacted by our current version of the mod installed.

SIDE NOTE FOR CRASH LOG ENTRY IN ISSUE FORM:

Because this is a public server I administrate, it'd not be smart for me to remotely crash it, as it'd disrupt gameplay. Another issue being that the output log could potentially leak info that we don't want to give out, although this may be rare, it's a risk I do not wish to take.

Instead, I will link a snippet of the latest.log file that includes the chat saying death.attack.matter_cannon.

Which minecraft version are you using?

1.20

On which mod loaders does it happen?

Fabric

Crash log

https://gist.github.com/TywrapStudios/7fbdb2ecd4e0fe8a340dc31c459eac23

shartte commented 1 month ago

SIDE NOTE FOR CRASH LOG ENTRY IN ISSUE FORM:

F3+C does not crash your server, only the client.