search

AppliedEnergistics / Applied-Energistics-2

A Minecraft Mod about Matter, Energy and using them to conquer the world..
https://appliedenergistics.github.io/
Other
1.44k stars 659 forks source link

Cell LEDs sometimes have black pixels #8126

Open Mithi83 opened 3 months ago

Mithi83 commented 3 months ago

Describe the bug

Sometimes you can notice that the cell LEDs are not fully colored but have black pixels, for example like this: drive

Picture taken on a 4k resolution 9 blocks from the ME Drive using a Nvidia 4090.

This is most notably if you move around in the world or move the mouse and happens only sometimes.

How to reproduce the bug

Place down a ME Drive, populate it with disks of various states and power it. Move (at least) 9 blocks away from it and look at it. Move around the mouse slowly and observe that sometimes the color of the LED has black pixels in it.

Expected behavior

Uniformly colored cell LEDs independent of the distance to the drive.

Additional details

I would expect a Z-fighting issue here due to the very small distance of 0.001f between the black pixel in the cell model texture and the LED pixel.

It is relatively hard to notice so I'd say it is a low prio bug.

Which minecraft version are you using?

1.21

On which mod loaders does it happen?

NeoForge

Crash log

Selfcompiled, current main branch

davethemodderguy commented 2 months ago

I don't see this problem on my side, did you tried updating to the latest version

Mithi83 commented 2 months ago

I'm using the latest main branch for my own development and can still reproduce it.

I'm not sure what conditions are relevant, could be a GPU driver issue. I'm running it on a 4k Display which probably makes it easier to spot than on lower resolutions as there are more pixels that could show that behavior. It is also quite hard to find a position and angle to show that behavior. You'll have to move the mouse very slowly to find a setting that shows the problem.

A bit more testing showed that if I change the black pixels in the base texture (src/main/resources/assets/ae2/textures/block/drive/drive_cells.png) to transparent I can't see the issue anymore. But from what I've gathered about Z-buffers so far it does not seem likely that the write to the Z-buffer would be skipped for transparent parts in textures. This would contradict my Z-fighting theory.