search

AppliedEnergistics / Applied-Energistics-2

A Minecraft Mod about Matter, Energy and using them to conquer the world..
https://appliedenergistics.github.io/
Other
1.42k stars 649 forks source link

Conversion Monitors and Storage Monitors cannot be locked currently #8179

Open Saereth opened 2 weeks ago

Saereth commented 2 weeks ago

Describe the bug

MC 1.21.1 Neoforge Setting an item on either the conversion or storage monitor works fine, you can insert and extract items as expected on the conversion monitor but empty hand shift+right click also still clears the monitor instead of locking it. Also tried with a wrench, doesnt work either.

How to reproduce the bug

Barebones mc 1.21.1 pack with just jei and ae2 can reproduce this issue

Expected behavior

I would expect to be able to lock the monitors

Additional details

No response

Which minecraft version are you using?

1.21

On which mod loaders does it happen?

NeoForge

Crash log

not a crash

Mithi83 commented 2 weeks ago

Using a debugger I see that shift-rightclicking empty-handed on a storage monitor calls onUseItemOn rather than onUseWithoutItem as I would have expected in AbstractMonitorPart. heldItem is "minecraft:air" when the main hand is empty.

MRX8024 commented 2 weeks ago

Same thing on 1.20.1 fabric.