search

AppliedEnergistics / Applied-Energistics-2

A Minecraft Mod about Matter, Energy and using them to conquer the world..
https://appliedenergistics.github.io/
Other
1.45k stars 669 forks source link

Coloured terminals overly bright with shaders #8205

Open Leah96xxx opened 1 month ago

Leah96xxx commented 1 month ago

Describe the bug

While using shaders that use Integrated PBR+ (like the Complimentary shaderpacks), any terminals placed on coloured cables will light up with full brightness, washing out the face of the terminal entirely and making them look like solid white squares. It also causes the cable itself to be lit to full brightness.

2024-10-03_22 08 15

How to reproduce the bug

  1. Install All The Mods 9 from Curseforge
  2. Enable one of the included Complimentary shaderpacks
  3. Place any terminal on a coloured ME cable
  4. Get blinded irl by the bright light

Expected behavior

Terminals and cables are at a normal brightness and the terminal faces' colours aren't blown out

Additional details

I'm playing the ATM9 pack with Embeddium and Occulus. The issue occurs when using any of the included Complimentary shaderpacks with Integrated PBR+ enabled.

I've spoken to some of the Complimentary team on their Discord and they suggest that AE2 may not be playing nicely with the shaders. They suggest that the terminals may just be setting their block to 15 brightness and washing themselves out.

Which minecraft version are you using?

1.20

On which mod loaders does it happen?

Forge

Crash log

https://pastebin.com/Ltjg8UkK

shartte commented 1 month ago

FYI the terminals look fine in 1.21 with complimentary image

Is this only with specific settings? You mention PBR but I wonder how that's supposed to work without mod-specific materials...

Leah96xxx commented 1 month ago

I can't quite see from your screenshot, but it looks like yours are just on fluix ME cables, not coloured ones. The issue only exists on terminals placed on coloured cables.

The shaderpacks I tested with are Complimentary Reimagined and Complimentary Unbound. Both were tested with and without Euphoria Patches, and both with default settings. I also disabled any shader settings that would affect glowing surfaces and lighting, but nothing made a difference except changing from IntegratedPBR+ to labPBR (which disables all glowing textures, so is not a solution).

shartte commented 1 month ago

The face of the terminal is indeed set to 15 brightness since there's not a lot of other ways to emulate emissiveness in non-shader environments.

I'd honestly have to check this on 1.21 and see if it still happens there...