search

AppliedEnergistics / Applied-Energistics-2

A Minecraft Mod about Matter, Energy and using them to conquer the world..
https://appliedenergistics.github.io/
Other
1.45k stars 668 forks source link

EMI BOM (synthetic favourites) support #8214

Open jeytee84 opened 1 month ago

jeytee84 commented 1 month ago

Reasons why it should be considered

The recipe tree and the generated bill of materials in EMI are some of the best QoL features in expert modpacks like GregTech. Having it before accessing an ME system is a treat, but losing it once you get ME access is quite sad.

Describe the feature

This mod add this functionality, but it's only for fabric. https://www.curseforge.com/minecraft/mc-mods/ae2-emi-crafting-integration/files/5160115 https://github.com/emilyploszaj/emi/issues/696#issuecomment-2347974496

EMI supports this, AE2 does not

shartte commented 1 month ago

The last time we had this enabled it caused massive performance issues. I suppose we can look at what that addon does in detail to revisit this

jeytee84 @.***> schrieb am Do., 17. Okt. 2024, 10:40:

Describe the feature

This mod add this functionality, but it's only for fabric.

https://www.curseforge.com/minecraft/mc-mods/ae2-emi-crafting-integration/files/5160115

emilyploszaj/emi#696 (comment) https://github.com/emilyploszaj/emi/issues/696#issuecomment-2347974496

EMI supports this, AE2 does not

Reasons why it should be considered

The recipe tree and the generated bill of materials in EMI are some of the best QoL features in expert modpacks like GregTech. Having it before accessing an ME system is a treat, but losing it once you get ME access is quite sad. Additional details

No response

— Reply to this email directly, view it on GitHub https://github.com/AppliedEnergistics/Applied-Energistics-2/issues/8214, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJT6V4FVLXJFUQIVWSJZEDZ35ZXVAVCNFSM6AAAAABQDGPITKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU4TIMBTGQYDQMQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

jeytee84 commented 1 month ago

maybe a config option for it?

ramidzkh commented 1 month ago

The addon doesn't seem to do much differently in this area? https://github.com/blocovermelho/ae2-emi-crafting/blob/master/src/main/java/org/blocovermelho/ae2emicrafting/client/handler/generic/Ae2BaseRecipeHandler.java#L56-L59 https://github.com/blocovermelho/ae2-emi-crafting/blob/master/src/main/java/org/blocovermelho/ae2emicrafting/client/helper/InventoryUtils.java#L26

The only performance downgrade I could see is the refresh every 400ms/50ms (when a recipe is open), requiring all the stacks to be iterated and such. I could try to do some investigation if that was it @shartte

jeytee84 commented 1 month ago

I've been testing it for an hour now, works just fine through Sinytra Connector as detailed here, it could totally be at least an option disabled by default.

theboo commented 3 weeks ago

i could see craftables causing a massive performance hit... but the synthetic faves shouldnt be too bad? really sad when i made my ae2 terminal in e10 and found i could no longer use my craft one/all to inventory EMI hotkeys while in my ME system crafting terminal. Seemed weird cuz when i hover over the items in my synthetic faves, the tooltip can already see if i have the items needed for the craft, so EMI is seeing what is in the ME system somehow already...