Closed chuckhoupt closed 5 years ago
Something is broken. (I’m logged in, unlike last time there was a problem.) I don’t see any compare button on the pull#177, and no file-by-file diffs. Then I set the Code branch = ref-iso-key, and drilled down to docs/docs/ref. But at top, it shows the message: Cannot retrieve the latest commit at this time. So I can’t see any of the changes.
On Nov 3, 2019, at 8:32 AM, Chuck Houpt notifications@github.com wrote:
@chuckhoupt requested your review on: #177 Refactor ISO links into ref-page layout..
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or unsubscribe.
Factoring the link out into the layout allows for easier maintenance, and consistent rendering. Future redesign of the link text/position/styling is also made simpler.
This pull request is a pure refactoring: the generated doc is identical to existing doc. I'd like to have this pull accepted before fixing a few missing ISO link.
Originally mention in:
message://%3cFAFFA9FF-ABBF-4854-8D04-195A73DFA497@habilis.net%3e