search

AppliedMathematicsANU / plexus-form

A dynamic form component for react using JSON-Schema.
MIT License
134 stars 31 forks source link

Update react-ghfork from ^0.2.2 to ^0.3.0 #35

Closed martijnvermaat closed 9 years ago

martijnvermaat commented 9 years ago

Fixes incompatibilities in peer dependencies.

$ git clone https://github.com/AppliedMathematicsANU/plexus-form.git
$ cd plexus-form/
$ npm install

...

npm WARN optional dep failed, continuing fsevents@0.3.6
npm ERR! Linux 3.2.0-4-amd64
npm ERR! argv "/usr/bin/iojs" "/usr/bin/npm" "install"
npm ERR! node v1.3.0
npm ERR! npm  v2.5.1
npm ERR! code EPEERINVALID

npm ERR! peerinvalid The package react does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer react-ghfork@0.2.2 wants react@^0.12.2
npm ERR! peerinvalid Peer react-hot-loader@1.2.7 wants react@>=0.11.0

npm ERR! Please include the following file with any support request:
npm ERR!     /tmp/plexus-form/npm-debug.log
odf commented 9 years ago

Why the hell are ^0.12.2 and >=0.11.0 incompatible? Last time I looked, 0.12.2 was larger or equal to 0.11.0.

martijnvermaat commented 9 years ago

To be honest, I didn't really understand this either. I'm also unsure how this was not a problem earlier, but perhaps React 0.13.3 (two days ago) had something to do with it?

Anyway, this update cannot hurt and fixes the problem, thanks :)

odf commented 9 years ago

After a quick look at the documentation, I wouldn't be terribly surprised if npm's semver syntax was Turing completely. :-) Anyway, glad the update apparently fixed things.

bebraw commented 9 years ago

^ includes everything greater than a particular version in the same major range by definition. The original peer dependency at gh-fork was too strict so I loosened it a lot. Semver...

Thanks for the fix!