ApplikeySolutions / PandoraPlayer

🅿️ PandoraPlayer is a lightweight music player for iOS, based on AudioKit and completely written in Swift.
https://applikeysolutions.com/
MIT License
1.19k stars 179 forks source link

Retain cycling issues fixed #19

Open Adiletkozha opened 6 years ago

Adiletkozha commented 6 years ago

1) There was retain cycle in line inside PlayerSlider.swift:
issue:var delegate: PlayerSliderProtocol? fix: weak delegate: PlayerSliderProtocol? 2) Problem also related to retain cycles inside block which is inside prefetchItems function within PandoraPlayer.swift issue: item = DispatchWorkItem(block: { fix: item = DispatchWorkItem(block: {[unowned self] in 3) targetColumn value inside CenterCellCollectionViewFlowLayout had been computing incorrectly issue: let targetColumn = floor(proposedContentOffset.x/w + 1) fix: let targetColumn = floor(proposedContentOffset.x/(w+self.minimumLineSpacing) + 1)