search

Appliscale / xprof

A visual tracer and profiler for Erlang and Elixir.
Other
276 stars 33 forks source link

Update query for monitored function #90

Open gomoripeti opened 6 years ago

gomoripeti commented 6 years ago

Allow to update the query (in place in the graph title bar) for already monitored functions. This can be done without backend modification with a demonitor/monitor combo. Some restrictions may apply such as only allow to modify the match-spec part and not module and function. Some attention needs to be payed for error handling, eg if the new query is invalid keep the old graph unchanged.

afronski commented 6 years ago

In such case I think without additional marker on graph it may introduce confusion (e.g. vertical line that marked change in the query with before / after) - so we need to remember about that too in this task.

gomoripeti commented 6 years ago

True, I just had in mind (laziness) not to reenter the query and just clear the graph all together. But good idea to keep old results but with a very much visible mark that from a certain point we are monitoring something completely different.