search

ApplySci / aim

All-Ireland Mahjong mobile app
1 stars 1 forks source link

favouriting before seats are assigned gets messed up when seats get assigned, as IDs change #22

Closed ApplySci closed 2 months ago

ApplySci commented 2 months ago

We need a way to have a unique player ID that remains unperturbed by seating ID. We can use the registration ID for this, we just need to work out how.

ApplySci commented 2 months ago

This has been temporarily bypassed, by removing player names from the app before seats are assigned. However, it would still be best to solve the underlying problem, and have player names available in the app to follow, before seating is assigned

ApplySci commented 2 months ago

plan: have registration ids always be over 1000, and use that in the app to detect which regime we are in: seating ids or registration ids. Also, we need to pass both seating id and registration id into firebase & onto the app, so that when a user selects a player, and the player details get updated with a seating id, we can convert the selected player preference from a registration id to a seating id

ApplySci commented 2 months ago

fixed across multiple commits.