AppoloDev / bolt-seo

Bolt 5 - SEO extension
https://appolo.fr
MIT License
10 stars 9 forks source link

SEO content appears to not persist in DB #5

Closed crim3hound closed 3 years ago

crim3hound commented 3 years ago

First of all, thank you for porting this extension to Bolt 4! Great work! However, it appears that the content is not being saved to the database. Not sure what the issue could be. Can you advise?

Fredxd commented 3 years ago

Hi Do you have check in bolt_field_translation table if you have something ? In your developer console do you have any errors?

Thanks for feedback

Thibault-Mantalo commented 3 years ago

HI, Thank you very much for the work done! Indeed, I have the same technical problem. No errors on the logs / debug side.

I haven't had time to look in more detail yet. But it's as if auto-mapping doesn't work with synfony ORM.

I will keep you posted if I find a solution.

PS : sorry for my english, i'm french.

Fredxd commented 3 years ago

HI, Thank you very much for the work done! Indeed, I have the same technical problem. No errors on the logs / debug side.

I haven't had time to look in more detail yet. But it's as if auto-mapping doesn't work with synfony ORM.

I will keep you posted if I find a solution.

PS : sorry for my english, i'm french.

Hi,

Actually only single hidden field is use to store data. Data is stored in stringify JSON, and provide by others SEO fields or content fields depending configuration (title, payload....) So you can check if you have any value in this single field. Sorry i am not on it so i can't tell you it's name. Or you can check if JS file is correctly loaded.

PS: Ahah no problem i am french too ;)

Fredxd commented 3 years ago

Hi Guys, Still here ?

Thibault-Mantalo commented 3 years ago

Hi, yes still there. I have to look into it in January

Fredxd commented 3 years ago

@Thibault-Mantalo Ok let me know if you see something. I can't reproduce it and it seems to work in some users

crim3hound commented 3 years ago

Still here. Sorry, I've been held up as well, but I was also trying to see what could be causing the issue. Will update if I find anything after the holidays.

crim3hound commented 3 years ago

Hi @Fredxd. I have tried to look at the SEO extension, and I have seen this hidden input field <input type="hidden" name="fields[seo]" id="field-seo" value="">. I assume this is what you were talking about where SEO input is stored in stringified JSON? If so, it appears that no data is saved to it.

The seo.js file seems to load correctly; unless there is another JS file that needs to be loaded? Could you help to confirm where and how (which file) exactly the SEO data is saved to the hidden input? I also noted that if I manually input a value to fields[seo] via element inspector, it persists even on reload, which leads me to think that is where the issue might be?

Fredxd commented 3 years ago

Hi @crim3hound. I think seo.js file is incomplete, i have issue now on my dev stack but i have loose my local history. I will try to do this but i don't know when. If someone want try to do it, it miss this:

Fredxd commented 3 years ago

I have do some adjustments on develop branch. Can you try it and tell me if it's better ?

crim3hound commented 3 years ago

Thanks @Fredxd. Let me check it out.

crim3hound commented 3 years ago

Hey @Fredxd. I made the changes you have on your develop branch, and right now there is a json_decode syntax error. Can you advise?

Screenshot 2021-01-15 124813

Fredxd commented 3 years ago

@crim3hound Should be fixed ;)

crim3hound commented 3 years ago

Confirmed. Thanks for the great work, @Fredxd!

crim3hound commented 3 years ago

Will you push a release so users can update via composer?

Fredxd commented 3 years ago

Great ! Thanks for feedback i will do a release in few minutes

I close this issue, if you have any problem you can open a new issue, or if you want improve it, feel to free to create a PR ;)

Fredxd commented 3 years ago

I have tag to 1.0.2 ;)

Thibault-Mantalo commented 3 years ago

Hi !

I confirm that I just tested on my side and it works too.

Thank you for your work !