AppraiseDev / Appraise

Appraise code used as part of WMT21 human evaluation campaign
BSD 3-Clause "New" or "Revised" License
22 stars 12 forks source link

Change thumbs-up/down to highlight/de-highlight #149

Closed GuoNa1 closed 6 months ago

snukky commented 6 months ago

Thanks for this change! I'd prefer to have it optional/configurable by defining a new campaign option here: https://github.com/AppraiseDev/Appraise/blob/c64e3aaec12141b2df938194734ffc45618ab441/EvalView/views.py#L2220 and based on it either swap the .html file (like here https://github.com/AppraiseDev/Appraise/blob/c64e3aaec12141b2df938194734ffc45618ab441/EvalView/views.py#L2403) or (imo, preferrable) pass a new variable to the the existing *-newui.html file and swap between the two versions.

snukky commented 6 months ago

We may also want to update the instructions accordingly as they still mention "thumbs up/down".

GuoNa1 commented 6 months ago

Created a new PR(https://github.com/AppraiseDev/Appraise/pull/150) to replace it.