ApproxSymate / klee

KLEE Symbolic Virtual Machine for Numerical Precision Analysis
Other
0 stars 0 forks source link

Non-constant address assertion failure with adpcm_encoder.c #17

Closed Himeshi closed 7 years ago

domainexpert commented 7 years ago

Good work @Himeshi, but it seems the code is not uniformly indented. To properly indent the program, I use git-clang-format which can be found here: https://opensource.apple.com/source/clang/clang-703.0.31/src/tools/clang/tools/clang-format/git-clang-format. You can download the program into one of the folders specified in your PATH, say ~/bin, assuming $HOME/bin is in your PATH (to check what are in your PATH, say echo PATH). Now, once it is downloaded into say, ~/bin/git-clang-format, you need to make it executable. Say:

chmod +x ~/bin/git-clang-format`

After this, you can now say:

git clang-format

in the klee folder to indent your file, after adding the file to be formatted using git add. So, if I were you, I would, load this PR's SymbolicError.cpp into Eclipse, use Eclipse's Indent source to indent just the modified part, save it, add SymbolicError.cpp using git add --all, and execute git clang-format to standardize the indentation. In case SymbolicError.cpp gets modified, again use git add --all to add it, and so on until SymbolicError.cpp is stabilized, where it is no longer gets modified by git clang-format. Now, finally add it using git add --all and commit -m "Corrected indentation in SymbolicError.cpp". Would you like to try this?

domainexpert commented 7 years ago

@Himeshi After done amending the commit message, you need to force push the issue16 branch via: git push -f.

domainexpert commented 7 years ago

@Himeshi Thank you! Merging now.