AppsFlyerSDK / AppsFlyerFramework

AppsFlyer Apple SDK
https://support.appsflyer.com/hc/en-us/articles/207032066-AppsFlyer-SDK-Integration-iOS
Other
166 stars 89 forks source link

Mac Catalyst support discussion #101

Closed chethanashastry closed 4 years ago

chethanashastry commented 4 years ago

We are using the appsflyer SDK in our project. Since we are planning to support for mac, is there a SDK available with catalyst support for mac? Is it in the pipeline?

andr-ggn commented 4 years ago

Upcoming AppsFlyerFramework should support Catalyst. Next week.

andr-ggn commented 4 years ago

https://github.com/AppsFlyerSDK/AppsFlyerFramework/releases/tag/5.1.0-beta.1

This is beta, so there might be some issues

chethanashastry commented 4 years ago

Thanks a lot for the timely support. The compilation issue is resolved.

andr-ggn commented 4 years ago

Please, post any Catalyst project issues here. thx

itayAmza commented 4 years ago

@andr-ggn Do you guys have any timeline for when the Mac Catalyst xcframework will be available via Cocoapods? (Beta is good too)

andr-ggn commented 4 years ago

We will wait until Cocoapods will be released with xcframework support(not a beta) and only then will push there

andr-ggn commented 4 years ago

For now you can download it directly and include it in old fashion way

xiao99xiao commented 4 years ago

Cocoapods with XCFramework is already here. Firebase SDK is releasing new versions in XCFrameworks.

henrytkirk commented 4 years ago

I'm receiving an error compiling for Catalyst:

.../AppsFlyerLib.framework/AppsFlyerLib(AFSDKKeychainFactory.o), building for Mac Catalyst, but linking in object file built for iOS Simulator, file '.../AppsFlyerLib.framework/AppsFlyerLib' for architecture x86_64

I'm using the latest version via cocoapods.

andr-ggn commented 4 years ago

@henrytkirk To support Mac Catalyst add framework manually from this repo. Our cocoapods does not support Catalyst yet. AppsFlyerFramework/Mac Catalyst/

xiao99xiao commented 4 years ago

@andr-ggn Is there any blocker issues that keep you from pushing the XCFrameworks version to Cocoapods?

andr-ggn commented 4 years ago

Good news! 5.4.0 will contain Mac Catalyst support via CocoaPods! ~2 weeks

anatoliykant commented 4 years ago

Guys, what about version 5.4.0, when can I wait?

danwey commented 4 years ago

~2 weeks after........5.4.0 where is?

andr-ggn commented 4 years ago
af-fess commented 4 years ago

https://github.com/AppsFlyerSDK/AppsFlyerFramework/blob/master/AppsFlyerFramework.podspec

bingosabi commented 3 years ago

@andr-ggn I'm running 5.4.4 via cocoapods 1.9.3 on Xcode 11.6 and am seeing the issue @henrytkirk was having before this was 'fixed'. I also tried version 5.4.0 of the pod to make sure it haven't rebroken... but still getting:

In /Users/default/Development/weve/weve-app-ios/Pods/AppsFlyerFramework/iOS/AppsFlyerLib.framework/AppsFlyerLib(AppsFlyerHTTPClient.o), building for Mac Catalyst, but linking in object file built for iOS Simulator, file '/Users/default/Development/weve/weve-app-ios/Pods/AppsFlyerFramework/iOS/AppsFlyerLib.framework/AppsFlyerLib' for architecture x86_64

gang018 commented 3 years ago

@andr-ggn I'm running 5.4.4 via cocoapods 1.9.3 on Xcode 11.6 and am seeing the issue @henrytkirk was having before this was 'fixed'. I also tried version 5.4.0 of the pod to make sure it haven't rebroken... but still getting:

In /Users/default/Development/weve/weve-app-ios/Pods/AppsFlyerFramework/iOS/AppsFlyerLib.framework/AppsFlyerLib(AppsFlyerHTTPClient.o), building for Mac Catalyst, but linking in object file built for iOS Simulator, file '/Users/default/Development/weve/weve-app-ios/Pods/AppsFlyerFramework/iOS/AppsFlyerLib.framework/AppsFlyerLib' for architecture x86_64

Hi. I have the same problem using 6.0.3

xiao99xiao commented 3 years ago

@andr-ggn I can confirm the issue regressed in 6.0.x version.

thefaj commented 3 years ago

Thirded—it's broken in 6.0.3. Any fix from the company on this showstopper? (might want to reopen the issue @af-fess)

victorBaro commented 3 years ago

I opened https://github.com/AppsFlyerSDK/AppsFlyerFramework/issues/134 which might be related?

thefaj commented 3 years ago

I opened #134 which might be related?

Thanks—I added a comment there. Kind of disappointing there isn't a response yet.

patskovn commented 3 years ago

Please fix support for Mac catalyst. Versions 5.4.0 and 5.4.4 also broken