search

AppsFlyerSDK / AppsFlyerFramework

AppsFlyer Apple SDK
https://support.appsflyer.com/hc/en-us/articles/207032066-AppsFlyer-SDK-Integration-iOS
Other
166 stars 89 forks source link

AppsFlyerLib.json not updated for Carthage #119

Closed NiltiakSivad closed 3 years ago

NiltiakSivad commented 3 years ago

SDK Version

5.2.0

What did you do?

Ran carthage update --platform iOS

What did you expect to happen?

To get the latest AppsFlyer build available which is 5.4.1

What happened instead?

It thinks 5.2.0 is the latest version because

these links were updated https://github.com/AppsFlyerSDK/AppsFlyerFramework/commit/b5e679879e6bc63753353c8df20cd8aa081151a8

but https://raw.githubusercontent.com/AppsFlyerSDK/AppsFlyerFramework/master/AppsFlyerLib.json have not been updated to include links to the latest binary version numbers.

andr-ggn commented 3 years ago

binary "https://raw.githubusercontent.com/AppsFlyerSDK/AppsFlyerFramework/master/Carthage/appsflyer-ios.json"

NiltiakSivad commented 3 years ago

@andr-ggn The README.md on the project repo should be updated as that link does not reflect the current documentation reference of:

image

The file should be deleted too to limit confusion.