AppsFlyerSDK / AppsFlyerFramework

AppsFlyer Apple SDK
https://support.appsflyer.com/hc/en-us/articles/207032066-AppsFlyer-SDK-Integration-iOS
Other
166 stars 89 forks source link

Unable to update framework #126

Closed clapslock closed 3 years ago

clapslock commented 3 years ago

Report

What did you do?

Run carthage update --platform iOS --cache-builds

What did you expect to happen?

For the framework to update

What happened instead?

An invalid json got returned

Please provide any other relevant information.

I get 404: Not Found when trying to fetch https://raw.githubusercontent.com/AppsFlyerSDK/AppsFlyerFramework/master/AppsFlyerTracker.json

wxmarek commented 3 years ago

File removed https://github.com/AppsFlyerSDK/AppsFlyerFramework/commit/7fee3eadf05c6eedb9dbc55aa1313881f22a2084 -> Moved to Carthage/appsflyer-ios.json

Use: https://raw.githubusercontent.com/AppsFlyerSDK/AppsFlyerFramework/master/Carthage/appsflyer-ios.json

@af-fess please update .md5 for carthage

pbartolome commented 3 years ago

And what about versions lower than 5.3.0? the file "https://raw.githubusercontent.com/AppsFlyerSDK/AppsFlyerFramework/master/AppsFlyerTracker.json" has been removed, and the new one only includes higher versions. Our Carthage update will fail trying to fetch 5.0.0, please restore that file or add the older versions to the new path.

The current Readme still says that for lower versions we should use the old json path "https://raw.githubusercontent.com/AppsFlyerSDK/AppsFlyerFramework/master/AppsFlyerTracker.json"

wxmarek commented 3 years ago

@pbartolome same issue. I found workaround https://raw.githubusercontent.com/AppsFlyerSDK/AppsFlyerFramework/5.1.0/AppsFlyerTracker.json

Select tag, find file and select RAW. Zip files from .json are still available.

af-fess commented 3 years ago

Merged the legacy versions: https://raw.githubusercontent.com/AppsFlyerSDK/AppsFlyerFramework/master/Carthage/appsflyer-ios.json

https://github.com/AppsFlyerSDK/AppsFlyerFramework/commit/ba8eb78f6a49a14cb23de16da89cbbf3d46495bf

jbrennan commented 3 years ago

I still think it’d be helpful to put the file back, as the segment-appsflyer-sdk at eg version 5.2.0 still points to the old file location (this is what I use in my project). Now when I try to install via Carthage, it fails because that JSON file has moved in this repo.

bddq commented 3 years ago

Why moving json file in the repo? 😠 You are breaking all CI integrations because you moved Carthage reference file.

af-fess commented 3 years ago

Thank you @bixcorp

We restored the files. The new versions will be pointed to
https://github.com/AppsFlyerSDK/AppsFlyerFramework/blob/master/Carthage/appsflyer-ios.json

The change is done to support Mac Catalyst