AppsFlyerSDK / AppsFlyerFramework

AppsFlyer Apple SDK
https://support.appsflyer.com/hc/en-us/articles/207032066-AppsFlyer-SDK-Integration-iOS
Other
164 stars 89 forks source link

Apple M1 arm64-simulator support #150

Closed quentinfasquel closed 3 years ago

quentinfasquel commented 3 years ago

Report

SDK Version

6.1.2

What did you do?

Integrating AppsFlyer with Swift Package Manager

What did you expect to happen?

Run AppsFlyer on simulator

What happened instead?

Missing architecture arm64-simulator

Please provide any other relevant information.

I am working on most recent's Apple MacBook Pro (processor Apple M1)

af-fess commented 3 years ago

We work on it. I will give you more information once I get more updates.

valerio-bettini commented 3 years ago

any update on this one??

davidhodge commented 3 years ago

Would love to see a fix for this. Thanks!

alextudge commented 3 years ago

Also experiencing this - unable to compile for iOS14 simulators with M1. With a lot of stripping and scripts I can get it to work for < iOS14 but not ideal!

af-obodovskyi commented 3 years ago

We are working on it to provide the solution as soon as possible.

Possible solution, untill we add arm64 support to AppsFlyerLib: Try to add arm64 to excluded architectures for iOS simulator in your project settings.

alextudge commented 3 years ago

Unfortunately that causes a lot of issues with all other packages

gilbertCardioCast commented 3 years ago

Running Xcode through Rosetta lets you build. Albeit not ideal but an easy work around.

vmvinoth commented 3 years ago

Running Xcode through Rosetta lets you build. Albeit not ideal but an easy work around.

This Works!!!

1 - With Xcode closed (Important) Go to finder -> Applications 2 - Right Click on Xcode and select "Get Info" 3 - On the info panel check "Open using Rosetta" 4 - Open Xcode again and build 5 - It WORKS

misolubarda commented 3 years ago

Just a question with a kind intention... What is the priority of fixing this issue? I wonder only because this is the last constraint I have in my project to let Xcode run without Rosetta support.

shakked commented 3 years ago

This is ridiculous. M1 has been released for months and AppsFlyer can't fix this issue? Literally the only SDK that doesn't work. Get it together.

gilbertCardioCast commented 3 years ago

Can we get a status on this please? @af-fess @af-obodovskyi

af-fess commented 3 years ago

To support arm64 simulator, any binary should be built with Xcode 12.

The min ios version will be changed from 8 to 9. Clients using Xcode 11 will not be able to use a new AppsFlyer SDK version.

We expect to release M1 support at the end of Feb.

davidhodge commented 3 years ago

There's always this option: https://bogo.wtf/arm64-to-sim.html

hepspl commented 3 years ago

There's always this option: https://bogo.wtf/arm64-to-sim.html

Confirmed. I've just used the tutorial and successfully made current version working. Recommended.

navartis commented 3 years ago

To support arm64 simulator, any binary should be built with Xcode 12.

The min ios version will be changed from 8 to 9. Clients using Xcode 11 will not be able to use a new AppsFlyer SDK version.

We expect to release M1 support at the end of Feb.

It seems to me that a few hours will be enough to rebuild the library using one of the Mac rental services.

For example https://www.macstadium.com (not advertising)

patskovn commented 3 years ago

Guys, any updates here? Its march already

navartis commented 3 years ago

Just checked latest 6.2.2 release that happened 11 days a go.

Still does not support....

navartis commented 3 years ago

@af-fess How about good news for us?;)

appsfcker commented 3 years ago

appsflyer received $210M in funding last year and its taking months just to rebuild your SDK with the newest Xcode? maybe you should add a few iOS job postings to your careers site?

af-fess commented 3 years ago

We still work on it. We expect M1 support in v6.3.0.

atrinh0 commented 3 years ago

@af-fess Hi Maxim, any updates or ETA on when we can expect M1 support?

lordzsolt commented 3 years ago

Imagine needing 4 months to rebuild your project. Makes you wonder what AppsFlyer is doing under the hood...

navartis commented 3 years ago

@lordzsolt Easy!

Google also can't do this with their GoogleMaps and GoogleSignIn libraries

Hm... May be AppsFlyerFramework and this Google libraries has cross dependencies... J

"Share, like, repost" please: https://github.com/googlesamples/google-services/issues/495 https://github.com/googlesamples/google-services/issues/496

af-fess commented 3 years ago

We are very sorry your experience is less than perfect.

These days we run a QA cycle. Here is a branch: https://github.com/AppsFlyerSDK/appsflyer-apple-sdk-qa/blob/dev/m1/appsflyer-apple-sdk-qa.podspec#L64

lordzsolt commented 3 years ago

@lordzsolt Easy!

Google also can't do this with their GoogleMaps and GoogleSignIn libraries

Hm... May be AppsFlyerFramework and this Google libraries has cross dependencies... J

"Share, like, repost" please: googlesamples/google-services#495 googlesamples/google-services#496

Considering the amount of shady stuff Google is doing under the hood, I'm unsure if this point helps AppsFlyerFramework 😅 (Specifically GoogleMobileAdsSDK, I don't know about these 2 you mentioned)

We are very sorry your experience is less than perfect.

These days we run a QA cycle. Here is a branch: AppsFlyerSDK/appsflyer-apple-sdk-qa@dev/m1/appsflyer-apple-sdk-qa.podspec#L64

That's good to hear. Hopefully by the time Apple releases M1 iPads, it'll be ready.

dima-xo commented 3 years ago

We expect to release M1 support at the end of Feb.

Great scheduling and speed of updates for a multi-million dollar company.

reddavis commented 3 years ago

Hey hey!

I've found the m1 branch in the QA repo. Is the QA process documented anywhere? Imma trying to work out whether:

  1. We can use the xcframework in the QA branch(understanding its possible to not be stable - but we'd like to submit bugs if we come across anything)
  2. Now there is an M1 branch, what are the steps to get that into the main repo? I guess - roughly when should we expect that to be in the remain repo
  3. If we find issues with with the QA builds, would you prefer us reporting issues in the QA repo or in this main one?

Thanks! 🙌

atrinh0 commented 3 years ago

Here is a branch: https://github.com/AppsFlyerSDK/appsflyer-apple-sdk-qa/blob/dev/m1/appsflyer-apple-sdk-qa.podspec#L64

For what it's worth, this branch is working on my m1. 🥳

Screenshot 2021-04-28 at 14 04 36

Edited: Use 'AppsFlyerFramework', '6.3.0', should have m1 support now

shakked commented 3 years ago

@atrinh0 How do you include that branch in cocoapods?

jhascoet commented 3 years ago

@atrinh0 How do you include that branch in cocoapods?

Simply put that in your podfile

pod 'appsflyer-apple-sdk-qa', :git => 'git@github.com:AppsFlyerSDK/appsflyer-apple-sdk-qa.git', :branch => 'dev/m1'

andr-ggn commented 3 years ago

You can use pod 'AppsFlyerFramework', '6.3.0' Also do not forget to update cocoapods sudo gem install cocoapods

navartis commented 3 years ago

🎉👍🥳

traktor74 commented 3 years ago

also works fine with SPM from '6.3.0' version

matheusalano commented 3 years ago

Hey. Is it possible to update carthage json files to support xcframeworks? Thanks.