AppsFlyerSDK / AppsFlyerFramework

AppsFlyer Apple SDK
https://support.appsflyer.com/hc/en-us/articles/207032066-AppsFlyer-SDK-Integration-iOS
Other
164 stars 89 forks source link

App not building due to Double-quoted include in framework header #155

Closed JavierSilvaFreeNow closed 1 year ago

JavierSilvaFreeNow commented 3 years ago

Report

SDK Version

6.1.4

What did you do?

Migrated the framework from Cocoapods to SPM

What did you expect to happen?

App to build successfully

What happened instead?

App fails to build due to "Double-quoted include" warning in AppsFlyerLib.h and AppsFlyerShareInviteHelper.h

Please provide any other relevant information.

We have the "Treat Warnings as Errors" setting enabled to prevent warnings from being unattended on our project. Unfortunately this also means that the warnings caused by the library are also treated as errors, which makes the build process fail.

rlziii commented 2 years ago

Any information or progress on this issue?

rlziii commented 2 years ago

This warning seems to have manifested backwards (at least within Xcode 13): instead of changing the headers in AppsFlyerLib.h or AppsFlyerShareInviteHelper.h to make the warnings disappear, I was able to change a header of my own from #import <AppsFlyerLib/AppsFlyerLib.h> to #import "AppsFlyerLib/AppsFlyerLib.h" to make the warnings go away. Strangely Xcode was showing the warnings within AppsFlyerFramework and not within my app so this solution wasn't very clear. 🤷‍♂️

SeanMcTex commented 2 years ago

Would also like to see a fix for this. (Also, hi @rlziii !)

rlziii commented 2 years ago

Can confirm that we are still seeing these warnings on the latest version of Xcode (13.1).

(👋 @SeanMcTex 👋)

mathaeus commented 2 years ago

Also getting those warnings for a long time already and would really appreciate if they could get fixed @andr-ggn. We are on 6.5.0.

leearmstrong commented 2 years ago

Any chance these could be fixed?

leearmstrong commented 1 year ago

Any update?

af-fess commented 1 year ago

The fix will come with v6.9.0 (next release)

af-fess commented 1 year ago

Possible duplicate of https://github.com/AppsFlyerSDK/AppsFlyerFramework/issues/203