AppsFlyerSDK / AppsFlyerFramework

AppsFlyer Apple SDK
https://support.appsflyer.com/hc/en-us/articles/207032066-AppsFlyer-SDK-Integration-iOS
Other
170 stars 92 forks source link

Distribute xcframework via Carthage #179

Closed CraigSiemens closed 2 years ago

CraigSiemens commented 3 years ago

Currently the Carthage json file only contain the .framework which doesn't work well with the simulator on M1 Macs. https://github.com/Carthage/Carthage/releases/tag/0.38.0 added support for distributing pre built xcframeworks.

It seems like it should be a pretty straight forward change to

nomadplanet commented 3 years ago

+1, yes please 🙏

matheusalano commented 3 years ago

+1

alinfarcas12 commented 3 years ago

+1

GZaccaroni commented 3 years ago

+1

MagFer commented 3 years ago

+1

tahadarendeli commented 3 years ago

I hope the last PR should merged quickly. Clearly, it will help us a lot.

matheusalano commented 2 years ago

@andr-ggn @af-fess any updates on this?

af-fess commented 2 years ago

As a temp solution, we will include https://github.com/AppsFlyerSDK/AppsFlyerFramework/pull/188 manually (this week). Our next step will be to include the flow to our release automation.

cassianomonteiro commented 2 years ago

Version 6.5.4 is not working. When trying to download the file below I get an error "not found".

https://github.com/AppsFlyerSDK/AppsFlyerFramework/releases/download/6.5.5/AppsFlyerLib.xcframework.zip

amit-kremer93 commented 2 years ago

@cassianomonteiro thats because we don't have 6.5.5. 6.5.4 should work now

cassianomonteiro commented 2 years ago

@amit-kremer93 6.5.4 is still not working. That version is listed on the carthage file definition, but then carthage fails fetching the latest version since that zip file is not available.

af-fess commented 2 years ago

@cassianomonteiro Can you please rebuild the project, the link workers properly: from Carthage - https://github.com/AppsFlyerSDK/AppsFlyerFramework/releases/download/6.5.4/AppsFlyerLib.xcframework.zip

and zip file exists: https://github.com/AppsFlyerSDK/AppsFlyerFramework/releases/tag/6.5.4

CraigSiemens commented 2 years ago

This should probably be a new issue. It's different from the original issue, the only similarity is that it's using Carthage.