search

AppsFlyerSDK / AppsFlyerFramework

AppsFlyer Apple SDK
https://support.appsflyer.com/hc/en-us/articles/207032066-AppsFlyer-SDK-Integration-iOS
Other
164 stars 89 forks source link

Integration via Swift Package Manager fails with "has no Package.swift manifest" #189

Closed scalessec closed 1 year ago

scalessec commented 2 years ago

Report

SDK Version

I can repro with 4.6.2 and 4.6.1. I haven't tried older releases. I'm using Xcode 13.1 (13A1030d).

What did you do?

I followed the Swift Package Manager instructions exactly as they are written in the README.

What did you expect to happen?

For the package to be added.

What happened instead?

The package fails to be added. The error is: /Package.swift has no Package.swift manifest for version 4.6.1 in https://github.com/AppsFlyerSDK/AppsFlyerFramework

Please provide any other relevant information.

This is the error you'd typically receive if the Package.swift file was missing from the root directory. This is obviously not the case in this scenario, so I'm unsure why this would be happening.

af-obodovskyi commented 2 years ago

@scalessec, hi, the versions, you have mentioned not support SPM.

joshuapoq commented 2 years ago

Not sure if it's related but we are also seeing issues with the latest hotfix and no issues on 4.6.0. I don't see how your PR addresses any issue here though unless the Package.swift has some weird character.

We are seeing the following issue which I believe is caused by an Xcode 13 issue.

❌  /.../SourcePackages/checkouts/Poq.iOS.AppsFlyer/Sources/AppsFlyerModule.swift:9:8: no such module 'AppsFlyerLib'

The issue I'm referring to in Xcode 13 is 77465707 stated in the release notes.

scalessec commented 2 years ago

Regarding the PR, TIL that trailing commas are valid swift syntax. For whatever reason though, the manifest is found on the PR branch and not found on the official tag so it might very well be some invalid/hidden character.