AppsFlyerSDK / AppsFlyerFramework

AppsFlyer Apple SDK
https://support.appsflyer.com/hc/en-us/articles/207032066-AppsFlyer-SDK-Integration-iOS
Other
173 stars 92 forks source link

Updated checksum to match binary artifact #275

Closed andibeqiri closed 7 months ago

JeremieDaigle2 commented 7 months ago

Anytime you guys are ready ! :D this is blocking https://github.com/AppsFlyerSDK/AppsFlyerFramework/issues/276#issuecomment-2042430730 We cleared our caches, its still not working though

galunecandrey commented 7 months ago

Please consider this PR as soon as possible. We also have this problem on CI/CD. One of the packages we use has a dependency on AppsFlyerLib. Clearing caches doesn't help.

JohnnyTseng commented 7 months ago

@af-obodovskyi Would you please merge this PR? Thank you!

srdanrasic commented 7 months ago

@amit-kremer93 @af-obodovskyi could you look into this with urgency? This is breaking many organisation's CIs.

JeremieDaigle2 commented 7 months ago

is there any good reason why this isnt merged in yet? this is blocking...

hbanzon commented 7 months ago

Thank you for prepping this PR! I could benefit from it as well 🙏

richroguetech commented 7 months ago

Please merge this. I need this!

af-obodovskyi commented 7 months ago

@richroguetech , @hbanzon , @srdanrasic , @JohnnyTseng

@scottlemke Please consider using one of the following repositories for the SPM. SPM support will be removed from the main repository because of the extremely long checkout time, which affects the SPM package integration time.

For statically linked library https://github.com/AppsFlyerSDK/AppsFlyerFramework-Static

For dynamically linked library https://github.com/AppsFlyerSDK/AppsFlyerFramework-Dynamic

For Strict (No IDFA colection) library https://github.com/AppsFlyerSDK/AppsFlyerFramework-Strict

ftp27 commented 7 months ago

@af-obodovskyi what release processes are you talking about? It's just links to binaries and zero source code :D With the same result you can publish separate version tags in separate branches

af-obodovskyi commented 7 months ago

@ftp27 not the release process, SPM package integration time. I will edit my comment

richroguetech commented 7 months ago

@af-obodovskyi can someone explain this? I used your repos and i got this:

. The /Frameworks/AppsFlyerLib.framework' specifies a MinimumOSVersion of '100.0' but contains a 32-bit architecture that is unsupported on iOS 12 and later.

Apple Developer Relations

hbanzon commented 7 months ago

@af-obodovskyi I get the following error using the Static library. Seems liek there's some changes that will be required on our end if we switch repos.

AppsFlyerLib is not a valid configured external dependency

hbanzon commented 7 months ago

Can we get more of a ramp up time to adapt to the new repos but in the meantime merge any of the PRs that fix this issue?

scottlemke commented 7 months ago

@af-obodovskyi I get the following error using the Static library. Seems liek there's some changes that will be required on our end if we switch repos.

AppsFlyerLib is not a valid configured external dependency

@hbanzon I assume you're using Tuist too? If so, you need to reference the static of dynamic library name to fix that issue. Something like: .external(name: "AppsFlyerLib-Static") or .external(name: "AppsFlyerLib-Dynamic")

hbanzon commented 7 months ago

Thank you @scottlemke!