search

AppsFlyerSDK / AppsFlyerFramework

AppsFlyer Apple SDK
https://support.appsflyer.com/hc/en-us/articles/207032066-AppsFlyer-SDK-Integration-iOS
Other
170 stars 92 forks source link

[suggestion] Read data receive by constants and check status value using enum #98

Closed GeraldoBastos closed 1 year ago

GeraldoBastos commented 4 years ago

I'm checking the sample page to read data in onConversionDataReceive for iOS in this URL: https://support.appsflyer.com/hc/en-us/articles/207032096-Deferred-deep-linking-getting-the-conversion-data#sdk-implementation.

I think that the good approach to read important values in Swift dictionary with the specific keys is using the constants, for example when I need to access the status (organic or non-organic) value and check if the first launch with respective keys: "af_status" and "is_first_launch" in installData param I don't use any variable/constant to find this data.

We can implement something like this to the data keys and check status value:

Captura de Tela 2019-10-11 às 10 22 40

And if the Appsflyer needs to change the keys, it'll not a problem for us that use the sdk because we use the constant to read the data receive.

af-fess commented 1 year ago

This issue has been inactive for a while, and will now be closed due to inactivity. If you still believe this is a valid issue, please feel free to reopen it or create a new issue with updated information.