search

AppsFlyerSDK / appsflyer-capacitor-plugin

AppsFlyer SDK plugin for Capacitor
MIT License
15 stars 26 forks source link

capacitor migrate to 4.0.0 #27

Closed sawaca96 closed 2 years ago

sawaca96 commented 2 years ago

capacitor 4.0.0 deployed! (release)

pazlavi commented 2 years ago

Hi @sawaca96, Thank you for this PR. As Capacitor v4.0.0 was released a day ago, we are not planning to migrate this plugin yet and enforce updating the Capacitor version and iOS Deployment Target on our clients. The iOS Deployment Target in our podspec file seems to be the only blocker for using Capacitor v4.0.0 with the existing plugin. As for now, it is possible to add the following Capacitor CLI Hooks: 

 "capacitor:sync:before": "sed -i -r -e \"s/s.ios.deployment_target  = '12.0'/s.ios.deployment_target  = '13.0'/gi\" node_modules/appsflyer-capacitor-plugin/AppsflyerCapacitorPlugin.podspec",

This will let you pump up the iOS Deployment Target and compile the app using the existing plugin.

MateiNenciu commented 2 years ago

I do not understand the part with enforce updating the Capacitor versions and deployment targets. You can release a version like 7.x.x and clients who do not wish to update the specs and move on can still use older versions. This above solution and #28 are basically "patches" that should be made in order to support newer Capacitor version and move with the flow.