AppsFlyerSDK / appsflyer-capacitor-plugin

AppsFlyer SDK plugin for Capacitor
MIT License
15 stars 25 forks source link

Capacitor 5 update #96

Closed MateiNenciu closed 1 year ago

MateiNenciu commented 1 year ago

This PR updates this plugin so it can be used with Capacitor 5. All steps from: https://capacitorjs.com/docs/updating/plugins/5-0 were followed + some updates to support BuildConfig from gradle 8+

This update does not modify minSdkVersion so it should work for clients who are switching to capacitor v5. Any suggestions are welcomed, maybe switching to a greater version like 7 (because this targets Java 17 and gradle 8+)

@pazlavi

parthnayak7448 commented 1 year ago

Waiting for this PR to merge so I can integrate in my project using Cap 5

ppriyankasen commented 1 year ago

Same here, waiting for this PR to get merged to support cap5

gelinger777 commented 1 year ago

+1

MattijsE commented 1 year ago

For people not wanting to wait: you can do npm i https://github.com/nowjobs/appsflyer-capacitor-plugin/tree/main to get capacitor 5 support inside your projects.

Once Appsflyer releases the Capacitor 5 version, then this fork will be removed.

MateiNenciu commented 1 year ago

@MattijsE I'm curious, why did you added the dist folder?

MattijsE commented 1 year ago

@MateiNenciu When using your branch I couldn't get it to compile without an extra build step, since it couldn't find the definitions. So by adding the dist folder this problem is solved.

sultanmyrza commented 1 year ago

@MattijsE adding dist folder can be avoided. In package.json add "prepare": "npm run build". I use prepare in my plugins when I want to install directly from github without publishing to npm etc.

ppriyankasen commented 1 year ago

@MattijsE Is there any target date to merge this PR?

MateiNenciu commented 1 year ago

The target date is when the maintainer decides to merge my PR or do the changes itself

parthnayak7448 commented 1 year ago

@pazlavi can you provide us update on this PR please

pazlavi commented 1 year ago

Updating the plugin and releasing a new version is on our roadmap for Q3. I don't have an ETA at this moment.

MateiNenciu commented 1 year ago

So basically you are saying that we should wait for Q3 to merge a simple platform update that is already done? All other plugins are already supporting Capacitor v5

pazlavi commented 1 year ago

We'll not release any new version without running a proper QA cycle and documenting the breaking changes. At this moment, our resources focus on other tasks.

MateiNenciu commented 1 year ago

Ok, anyone who want to use Capacitor v5 please feel free to use my fork till this understaffed corporation will handle this. Capacitor v5 was announced from april, it's not like it was released 2 days ago. I will strongly advise my data dept to look for an alternative MMP

louison commented 1 year ago

I effectively used the fork from @MateiNenciu in my current project and everything is working well. @suyundukov @gelinger777 @parthnayak7448 could you please find someone to approve and merge this PR once and for all 😄 ? Thank you in advance !

pazlavi commented 1 year ago

6.12.1 release and support now Capacitor 5