AppsFlyerSDK / appsflyer-cordova-plugin

AppsFlyer plugin for Cordova
MIT License
37 stars 71 forks source link

fix: import NonNull error #181

Closed giulianok closed 3 years ago

giulianok commented 3 years ago

This is based on this error https://github.com/AppsFlyerSDK/appsflyer-cordova-plugin/issues/153.

The reason we need this fix as part of the lib is that we use Capacitor and we automatically sync our projects which removes any manual changes.

Probably master is not the right target, please advice about the change and branch

pazlavi commented 3 years ago

Our plugin is not 100% compatible for use with Capacitor. To use this plugin with Capacitor, you have to make changes and customize the code by yourself. (Feel free to fork the project) We can't migrate the dependency to AndroidX as we still have to support Cordova versions below V9.0.0 when AndroidX is not supported. Despite all of the above I have some good news, we released a brand new plugin for Capacitor today. Please check out our new plugin documentation and implement the brand new Capacitor plugin. We strongly believe that this plugin is much better and more efficient than the old Cordova plugin and should be easy to use.

sfeast commented 3 years ago

@pazlavi I've run into #153 when trying to use v6.3+ of the plugin on android with Cordova (not capacitor). Surely there must be a way to continue supporting below v9 of android while also allowing folks to use the current version of the plugin with recent cordova-android/android sdk versions no? There are plenty of plugins that are doing similar things afaik.

pazlavi commented 3 years ago

@sfeast We'll investigate this in the future. In the meantime, you can use something that patches the plugin, like jetifier or cordova-plugin-androidx-adapter

sfeast commented 3 years ago

@pazlavi ah didn't realize that was all we needed as a workaround, thank you, yes works in the meantime 👍