AppsFlyerSDK / appsflyer-react-native-plugin

AppsFlyer plugin for React Native
MIT License
278 stars 198 forks source link

Fix for incompatible config for React Native Versions >= 0.69.X #434

Closed princefishthrower closed 7 months ago

princefishthrower commented 1 year ago

As the title states, this fixes warnings introduced for all react native versions greater than or equal to 0.69

This issue was brought up in both https://github.com/AppsFlyerSDK/appsflyer-react-native-plugin/issues/421 and https://github.com/AppsFlyerSDK/appsflyer-react-native-plugin/issues/395 but both were mysteriously closed.

amit-kremer93 commented 1 year ago

@princefishthrower thank you for your MR! we still need to check if this fix has any impact on previous version of react native

alexborton commented 1 year ago

Is this going to be merged? This is an issue in RN 69 +

amit-kremer93 commented 1 year ago

We will update about ETA for this fix

riteshsingh1 commented 1 year ago

any update on this? This issue is in RN 69 as well as in 70

roryf commented 1 year ago

@amit-kremer93 still an issue in 0.71, first output from metro is

warn Package react-native-appsflyer contains invalid configuration: "dependency.platforms.ios.podspecPath" is not allowed. Please verify it's properly linked using "react-native config" command and contact the package maintainers about this.
maulik54e commented 1 year ago

Any updates on this when this will get approval & merged in ..?

herbertfuchs commented 1 year ago

any updates on this one guys? Metrics being affected here in 0.71 :(

Tguntenaar commented 1 year ago

Please merge this PR

Darex1991 commented 1 year ago

Please merge :)

renanbronchart commented 1 year ago

Please possible to merge it? @0xJoelero @maulik54e @griarman ?

maulik54e commented 1 year ago

Please possible to merge it? @0xJoelero @maulik54e @griarman ?

i'm just package user same as you

professorkolik commented 1 year ago

@liaz-af any chance you can merge and release this PR 🙏 ?

Matiassimone commented 1 year ago

Simple workaround until this PR is merged https://github.com/AppsFlyerSDK/appsflyer-react-native-plugin/issues/395#issuecomment-1589241783

mina4gerges commented 1 year ago

any updates ?

joaquinvaz commented 12 months ago

Hello, any updates on this?

mrsasuuBeast commented 10 months ago

Any updates?

YohayBar commented 10 months ago

Any updates?

markui commented 9 months ago

Any updates? why is the appsflyer react native team not working towards this issue nor answering anything.

alexandermendes commented 9 months ago

While I agree it's annoying that this repository is apparently not being maintained constantly posting "any updates" is pointless. The answer is clearly no. And for those of us watching these threads we get spammed with such comments, or people clicking approve, just to click through and find nothing useful.

Considering this is ultimately a product that many people/businesses are paying for maybe we should all spam AppsFlyer customer services instead 🤷‍♂️

mikypilota commented 7 months ago

@af-fess @amit-kremer93 Hey, what's preventing this from getting merged in? We have a bunch of community reviews here, looks like a quick win to me.

Darex1991 commented 7 months ago

Nooo way O.o 1Y waiting, nice 🤣