search

AppsFlyerSDK / appsflyer-react-native-plugin

AppsFlyer plugin for React Native
MIT License
278 stars 198 forks source link

Explicitly check for is_first_launch instead of using JSON.parse #444

Closed kutsan closed 1 year ago

kutsan commented 1 year ago

I think it's better to have an explicit, TypeScript-friendly is_first_launch check instead of using the obscure JSON.parse variant. Besides that, loose equality operator (double equals) is generally not recommended and it's even disabled with linter rules.

It would be even better to not have the string "true" in is_first_launch type but I don't know why it was done this way.