search

AppsFlyerSDK / appsflyer-react-native-plugin

AppsFlyer plugin for React Native
MIT License
278 stars 198 forks source link

Warning due to expo peer dep #445

Closed gfrancischini closed 1 year ago

gfrancischini commented 1 year ago

Report

Plugin Version

6.8.2

On what Platform are you having the issue?

Typescript/NPM

What did you do?

yarn install

What did you expect to happen?

No errors/warning when installing this package on a pure React Native project (no Expo)

What happened instead?

warning " > react-native-appsflyer@6.8.2" has unmet peer dependency "expo@*".

Please provide any other relevant information.

Currently, expo is being listed as a peerDep. This is wrong as expo is not required for using this library.

Options: Remove it as a peerDep or set it to optional:

"peerDependenciesMeta": {
  "expo": {
    "optional": true
  }
}

Thanks

amit-kremer93 commented 1 year ago

Thank you for your suggestion. This will be added in the next release