search

AppsFlyerSDK / appsflyer-react-native-plugin

AppsFlyer plugin for React Native
MIT License
276 stars 197 forks source link

Add support for NSAdvertisingAttributionReportEndpoint through Expo config #494

Closed AdamGerthel closed 11 months ago

AdamGerthel commented 11 months ago

I've just had to write my own expo plugin to add the NSAdvertisingAttributionReportEndpoint value to info.plist in a React Native project - and I figured I might as well attempt to get that into this package as I think it should be supported out of the box.

The PR is not 100% ready to go because I think there's questions that needs answering first:

  1. Should the endpoint URL be hardcoded to https://appsflyer-skadnetwork.com or should the value be provided via the plugin config?
  2. Should this be an optional configuration?
amit-kremer93 commented 11 months ago

@AdamGerthel thank you for this MR, but we are not going to add this soon

AdamGerthel commented 10 months ago

Ok - then you could at least update the Expo installation documentation and add that they'll need to either write a custom expo config plugin or add the NSAdvertisingAttributionReportEndpoint value to ios.infoPlist in app.json.