AppsFlyerSDK / appsflyer-react-native-plugin

AppsFlyer plugin for React Native
MIT License
284 stars 202 forks source link

chore(android): add support for AGP 8 #495

Closed AndreiCalazans closed 4 months ago

AndreiCalazans commented 1 year ago

Change to support AGP 8 as mentioned here: https://github.com/react-native-community/discussions-and-proposals/issues/671

This does not remove package attribute from AndroidManifest to not lose compatibility with AGP < 8 (React Native < 0.71 versions).

I don't think it's worth maintaining logic to remove that attribute contitionally since it will only cause a warning to users on AGP 8 and above.

See Kudo's comment on AGP 8 issues with BuildConfig and setting JVM versions.

lafest commented 1 year ago

https://github.com/react-native-community/discussions-and-proposals/issues/671 this issue says that after adding namespace, you should delete package definition from AndroidManifest.xml file. Is this change not necessary?

felipecsl commented 1 year ago

react-native-community/discussions-and-proposals#671 this issue says that after adding namespace, you should delete package definition from AndroidManifest.xml file. Is this change not necessary?

yup that change is also necessary