AppsFlyerSDK / appsflyer-react-native-plugin

AppsFlyer plugin for React Native
MIT License
273 stars 196 forks source link

Fix Expo support on Android #558

Open iway1 opened 1 month ago

iway1 commented 1 month ago

Report

Plugin Version

6.14.3

On what Platform are you having the issue?

Android

Description

Hello,

Expo support in this library is currently broken / incomplete on Android. Specifically, after following the installations steps, onDeepLink handler will not be fired in case the app is backgrounded / running when the deep link is pressed.

This is because for this to work the MainActivity code has to override onNewIntent as specified here: https://dev.appsflyer.com/hc/docs/rn_deeplinkintegrate

However, this is not viable in Expo managed workflow because it involves manually editing native code. A config plugins should be added to modify this code during generation.

So, the expo setup guide is incomplete as it will not work on Android, and a config plugin is missing. Without this config plugin, this library does not support Expo since this critical functionality is missing.

github-actions[bot] commented 1 month ago

👋 Hi @iway1 and Thank you for reaching out to us. In order for us to provide optimal support, please submit a ticket to our support team at support@appsflyer.com. When submitting the ticket, please specify:

iway1 commented 1 month ago

@pazlavi I already talked to support about this, it was not helpful. This is not a "support" ticket, this is an issue with this library that needs to be fixed with code changes.

Additionally, I already fixed the issue in my own project with the linked pull request, so I don't need support because my project is working perfectly. I am opening this issue so that AppsFlyer team is aware that Expo support on Android is broken.

You should remove the support label from this issue and fix this issue, this is not a good look for AppsFlyer. Consider merging my pull request that fixes the issue.

akinzalowevidation commented 1 month ago

I am also experiencing this issue.